ExE Boss Assignee
	Description • 6 years ago

(Quoted from `indicators.scss`)
> Indicators
> - in a perfect world each indicator is composed of 2 classes that
>   combine to indicate how it should display.
> - one to indicate whether it is a block or a inline indicator
> - one to indicate what colour and icons it should halve
> - in practice there are multiple classes that indicate these things
>   and a few indicators that only have one class to serve both purposes
> **********************************************************************

Based on that, it seems like the CSS classes `.blockIndicator` and `.inlineIndicator` should be used.

In practice, `.overheadIndicator` is the most commonly used block indicator class, followed by the mishmash of other block indicator classes.

This bug serves to track the work needed in kuma and kumascript to migrate to using `.blockIndicator` (although `.overheadIndicator` might end up being used instead) and `.inlineIndicator` for determining the indicator type.

	Stephanie Hobson [:shobson]
	Comment 4 • 6 years ago

I'm sorry, I'm not on this project anymore and don't have time to do a review.

I am pleased to see this work moving forward though!

	Les Orchard [:lorchard]
	Comment 5 • 6 years ago

Comment on attachment 9010695 [details] [review]
Part 1 - Kuma: Prefer `.blockIndicator` for styling block indicators

I've also been a long time away from this project and won't be much help for a review.

	ExE Boss Assignee
	Comment 6 • 6 years ago

Comment on attachment 9010697 [details] [review]
Part 2 - KumaScript: Prefer `.blockIndicator` for styling block indicators

Can we get this merged before the “macro massacre” project¹ will require me to rebase this yet again?

¹ https://discourse.mozilla.org/t/next-steps-for-kumascript/32227

	Will Bamberg [:wbamberg]
	Comment 7 • 6 years ago

:Exe Boss, I'm not familiar enough with the Kuma front-end code to review this change. I suggest you ask Schalk Neethling (:espressive).

	ExE Boss Assignee
	Comment 8 • 6 years ago

(In reply to John Whitlock from https://github.com/mozilla/kuma/pull/4962#issuecomment-426333569)
> I think I'm the wrong person to review this. I can review style changes
> if you are trying to fix something that I can see on a particular page
> on MDN, because I can load the page in my browser before and after the
> change and see what the effect is. I'm not aware of any pages that this
> change would make a visual difference on.
> 
> This appears to be a refactoring of classes for some quality goal in
> the CSS source, which isn't clear to me. I think @schalkneethling
> or @hobinjk are better suited to review.

	John Whitlock [:jwhitlock]
	Comment 9 • 6 years ago

Comment on attachment 9010695 [details] [review]
Part 1 - Kuma: Prefer `.blockIndicator` for styling block indicators

We don't review PRs on Bugzilla

	ExE Boss Assignee
	Comment 10 • 6 years ago

https://discourse.mozilla.org/t/indicator-style-class-simplification-project-prefer-blockindicator-for-styling-block-indicators/31976/5 provides a much better overview of this than my summary above, or the previous link.

	[github robot]
	Comment 11 • 6 years ago

Commit pushed to master at https://github.com/mdn/kumascript

https://github.com/mdn/kumascript/commit/938e4de3b249fcf9f71528438850eef7d7eed941
Bug 1492018: Prefer `.blockIndicator` for styling block indicators (#830)

* Bug 1492018: Prefer `.blockIndicator` for styling block indicators

* Bug 1492018: Avoid using `style` attributes for styling indicators

* Bug 1492018: Use `.experimental` and `.indicator-warning` for {{ES7}}

	[github robot]
	Comment 12 • 6 years ago

Commit pushed to master at https://github.com/mozilla/kuma

https://github.com/mozilla/kuma/commit/ff3272518ad16c05b09489454390c8ba33cc15ba
Bug 1492018: Prefer `.blockIndicator` for styling block indicators (#4979)

See [bug 1492018](https://bugzil.la/1492018) for details.

## TODO
- [x] Add the `.properties` class to the `:matches(…)` selector (see [`ime-mode`](https://developer.mozilla.org/docs/Web/CSS/ime-mode) for a case where this is necessary)
- [x] Push remaining commits (3/3)

## Changes:
- Add support for snugging `.blockIndicator`.
- Add indicator colour override classes (obsoletes https://github.com/mozilla/kuma/issues/4962):
  - `.indicator-info` - grey
  - `.indicator-version` - blue
  - `.indicator-warning` - yellow
  - `.indicator-danger` - red
- Use classes instead of `style` attributes for ES7/Harmony and JSOverrides.
- Fix `<pre>` block and `.properties` table snugging.

---

review?(@schalkneethling)

	ExE Boss Assignee
	Comment 13 • 6 years ago

This removes the `.banner` and `.badge` style classes, which are no longer in use on MDN:
- https://developer.mozilla.org/search?locale=*&css_classnames=banner&topic=none
- https://developer.mozilla.org/search?locale=*&css_classnames=badge&topic=none

	BMO Automation
	Comment 15 • 4 years ago

MDN Web Docs' bug reporting has now moved to GitHub. From now on, please file content bugs at https://github.com/mdn/sprints/issues/ and platform bugs at https://github.com/mdn/kuma/issues/.