Closed Bug 1487656 Opened 6 years ago Closed 4 years ago

[Regression] Indicator snugging doesn’t work in browsers which don’t support :matches(…)

Categories

(developer.mozilla.org Graveyard :: Design, enhancement, P5)

All
Other
enhancement

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: e7358d9c, Assigned: e7358d9c)

References

()

Details

(Keywords: in-triage, Whiteboard: [points:1])

Attachments

(2 files)

Inspecting the minified stylesheet, it turns out that the minifier actually merged the :matches(…) and non‑:matches(…) blocks together, which breaks on browsers which don’t support :matches(…).

A temporary solution would be to comment out the :matches(…) block, but a long term one will require a way to tell the CSS minifier to not merge the :matches(…) and non‑:matches(…) blocks together.

```css
.note+.note, .note+.notice, .note+.overheadIndicator, .note+.warning, .note+p:empty+.note, .note+p:empty+.notice, .note+p:empty+.overheadIndicator, .note+p:empty+.warning, .note+p:empty+pre, .note+pre, .notice+.note, .notice+.notice, .notice+.overheadIndicator, .notice+.warning, .notice+p:empty+.note, .notice+p:empty+.notice, .notice+p:empty+.overheadIndicator, .notice+p:empty+.warning, .notice+p:empty+pre, .notice+pre, .overheadIndicator+.note, .overheadIndicator+.notice, .overheadIndicator+.overheadIndicator, .overheadIndicator+.warning, .overheadIndicator+p:empty+.note, .overheadIndicator+p:empty+.notice, .overheadIndicator+p:empty+.overheadIndicator, .overheadIndicator+p:empty+.warning, .overheadIndicator+p:empty+pre, .overheadIndicator+pre, .warning+.note, .warning+.notice, .warning+.overheadIndicator, .warning+.warning, .warning+p:empty+.note, .warning+p:empty+.notice, .warning+p:empty+.overheadIndicator, .warning+p:empty+.warning, .warning+p:empty+pre, .warning+pre, :matches(.warning, .overheadIndicator, .note, .notice, pre)+:matches(.warning, .overheadIndicator, .note, .notice, pre), :matches(.warning, .overheadIndicator, .note, .notice, pre)+p:empty+:matches(.warning, .overheadIndicator, .note, .notice, pre), pre+.note, pre+.notice, pre+.overheadIndicator, pre+.warning, pre+p:empty+.note, pre+p:empty+.notice, pre+p:empty+.overheadIndicator, pre+p:empty+.warning, pre+p:empty+pre, pre+pre {margin-top:-15px}
```
Flags: needinfo?(jwhitlock)
Attached file wiki.c464fc6e9c7d.css
Attached file Pull request
Assignee: nobody → e7358d9c
Status: NEW → ASSIGNED
See Also: → 906353
Flags: needinfo?(jwhitlock)
Priority: -- → P5
Whiteboard: [points:1]
Commits pushed to master at https://github.com/mozilla/kuma

https://github.com/mozilla/kuma/commit/a4e1ba81abb26c001d011b224c0f534265dea0e8
Bug 1487656 ‑ Comment out the indicator `:matches(…)` block for now

# External links:
- https://bugzil.la/1487656

https://github.com/mozilla/kuma/commit/fb753b0e5bdcdcd536c2ec42fcbc9537aa780a6a
Merge pull request #4961 from ExE-Boss/styles/wiki/indicators/fix-snugging

Bug 1487656 ‑ Comment out the indicator `:matches(…)` block for now
MDN Web Docs' bug reporting has now moved to GitHub. From now on, please file content bugs at https://github.com/mdn/sprints/issues/ and platform bugs at https://github.com/mdn/kuma/issues/.
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → WONTFIX
Product: developer.mozilla.org → developer.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: