Andreas Tolfsen ❲:ato❳ Assignee
	Description • 6 years ago

When the Marionette XPCOM component fails to initialise we should
log the error to the console and quit Firefox.  There is no point
in hanging around waiting for mozprocess to kill it.

	Henrik Skupin [:whimboo][⌚️UTC+1]
	Comment 1 • 6 years ago

Btw the same should actually happen when we fail to create the server socket.

	Maja Frydrychowicz :impossibus (was :maja_zf) (needinfo me)
	Comment 7 • 6 years ago
mozreview-review

Comment on attachment 8944462 [details]
Bug 1432212 - Log error and quit Firefox when Marionette fails to start.

https://reviewboard.mozilla.org/r/214650/#review220676

How about an extra try push that fakes a start-up failure to see how this change behaves when things are broken?

(Aside: in the future, include `marionette` in try syntax if you want Android Mn jobs to run. `marionette-e10s` doesn't exist on Android.)

	Maja Frydrychowicz :impossibus (was :maja_zf) (needinfo me)
	Comment 8 • 6 years ago
mozreview-review

Comment on attachment 8944460 [details]
Bug 1432212 - Lazily load log service in Marionette.

https://reviewboard.mozilla.org/r/214646/#review220678

	Maja Frydrychowicz :impossibus (was :maja_zf) (needinfo me)
	Comment 9 • 6 years ago
mozreview-review

Comment on attachment 8944461 [details]
Bug 1432212 - Await startup recorder by using async function.

https://reviewboard.mozilla.org/r/214648/#review220682

	Andreas Tolfsen ❲:ato❳ Assignee
	Comment 10 • 6 years ago

(In reply to Maja Frydrychowicz (:maja_zf) from comment #7)

> How about an extra try push that fakes a start-up failure to see
> how this change behaves when things are broken?

So Firefox quits as expected, however the harness still waits the
full elapsed timeout.  I’ve filed https://bugzil.la/1432792 about
this.

> (Aside: in the future, include `marionette` in try syntax if you
> want Android Mn jobs to run. `marionette-e10s` doesn't exist on
> Android.)

Oh thanks, I didn’t know that.

	Pulsebot
	Comment 11 • 6 years ago

Pushed by atolfsen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a496e8ddbe56
Lazily load log service in Marionette. r=maja_zf
https://hg.mozilla.org/integration/autoland/rev/22105e1fcb90
Await startup recorder by using async function. r=maja_zf
https://hg.mozilla.org/integration/autoland/rev/c7bb2d63ea0e
Log error and quit Firefox when Marionette fails to start. r=maja_zf

	Narcis Beleuzu [:NarcisB]
	Comment 12 • 6 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/a496e8ddbe56
https://hg.mozilla.org/mozilla-central/rev/22105e1fcb90
https://hg.mozilla.org/mozilla-central/rev/c7bb2d63ea0e