Closed Bug 1432792 Opened 6 years ago Closed 6 years ago

Harness should end test run when Firefox quits unexpectedly without an active socket connection

Categories

(Remote Protocol :: Marionette, enhancement, P3)

Product:
Remote Protocol
Component:
Marionette
Version:
Version 3
Type:
enhancement

Tracking

(firefox64 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla64
Tracking Flags:
Tracking Status
firefox64 --- fixed

People

(Reporter: ato, Assigned: whimboo)

References

Details

In https://bugzilla.mozilla.org/show_bug.cgi?id=1432212 I’ve patched
Marionette so that Firefox quits if the Marionette server cannot be
started.  The harness still waits for the full test timeout before
aborting the test, but we could end much sooner if we detect that
the Firefox instance (which is managed by the harness) quits unexpectedly.
What about crashes? We basically continue our tests after such a situation. So what needs to be made clear here is that at least no connection had been established.
Summary: Harness should end test run when Firefox quits unexpectedly → Harness should end test run when Firefox quits unexpectedly without an active socket connection
Priority: -- → P3
Oh wait, I think I know what you are referring to here:

https://dxr.mozilla.org/mozilla-central/rev/0e45c13b34e815cb42a9f08bb44142d1a81e186e/testing/marionette/client/marionette_driver/marionette.py#695-696

The problem here is that `is_running()` is still broken. See bug 1433905 which has to be fixed.
Depends on: 1433905
Depends on: 1465715
This was actually fixed by my mozprocess patch on bug 1433905.
Assignee: nobody → hskupin
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox64: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
Product: Testing → Remote Protocol
You need to log in before you can comment on or make changes to this bug.