Masayuki Nakano [:masayuki] (he/him)(JST, +0900) Assignee
	Description • 10 years ago

D3E defines InputEvent interface. We should need to implement it.

Currently, we cannot support .data without refactoring nsEditor. However, it's easy to implement isComposing attribute.

So, let's implement only isComposing, first.

	Masayuki Nakano [:masayuki] (he/him)(JST, +0900) Assignee
	Comment 1 • 10 years ago

D3E defines InputEvent interface for "input" and "beforeinput".

This patch implements InputEvent and exposes it to web contents.

The initial InputEvent implementation only supports .isComposing.
https://dvcs.w3.org/hg/dom3events/raw-file/tip/html/DOM3-Events.html#widl-InputEvent-isComposing

> true if the input event occurs as part of a composition session, i.e., after a compositionstart event and before the corresponding compositionend event.
> 
> The un-initialized value of this attribute MUST be false.

Implementing the other attribute, .data, needs more work in editor. Therefore, I'd like to implement only .isComposing first.

The internal event class is InternalEditorInputEvent since we already have WidgetInputEvent. So, InternalInputEvent isn't available with some macros.

InputEvent doesn't support document.createEvent() but supports ctor.

I'll request review to ehsan for the editor part.

	Olli Pettay [:smaug][bugs@pettay.fi]
	Comment 2 • 10 years ago

Comment on attachment 8403256 [details] [diff] [review]
Implement DOM InputEvent interface with isComposing attribute

+  }
+  else {

->

} else {

	Masayuki Nakano [:masayuki] (he/him)(JST, +0900) Assignee
	Comment 3 • 10 years ago

Rewriting the patch without creating nsIDOMInputEvent.

	Masayuki Nakano [:masayuki] (he/him)(JST, +0900) Assignee
	Comment 4 • 10 years ago

Comment on attachment 8403825 [details] [diff] [review]
Implement DOM InputEvent interface with isComposing attribute

Ehsan:

Could you review the editor part? "input" event has specific internal event, InternalEditorInputEvent, by this patch. Therefore, editor needs to dispatch input events with its instance. It needs to take isComposing which is true after compositionstart and compositionend. Therefore, the dispatcher needs to the state at constructing rather than at dispatching the event actually.

	Masayuki Nakano [:masayuki] (he/him)(JST, +0900) Assignee
	Comment 5 • 10 years ago

https://developer.mozilla.org/en-US/docs/Web/API/InputEvent

I'll land the patches soon.

	Masayuki Nakano [:masayuki] (he/him)(JST, +0900) Assignee
	Comment 6 • 10 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/8a2a1efffcd5

	Ryan VanderMeulen [:RyanVM]
	Comment 7 • 10 years ago

https://hg.mozilla.org/mozilla-central/rev/8a2a1efffcd5

	Jean-Yves Perrier [:teoli]
	Comment 8 • 9 years ago

Doc updated (thanks :masayuki for the help here!)
https://developer.mozilla.org/en-US/docs/Web/API/InputEvent.isComposing
https://developer.mozilla.org/en-US/docs/Web/API/InputEvent
https://developer.mozilla.org/en-US/docs/Web/API/InputEvent.InputEvent
and
https://developer.mozilla.org/en-US/Firefox/Releases/31#Interfaces.2FAPIs.2FDOM

	Masayuki Nakano [:masayuki] (he/him)(JST, +0900) Assignee
	Comment 9 • 9 years ago

(In reply to Jean-Yves Perrier [:teoli] from comment #8)
> Doc updated (thanks :masayuki for the help here!)
> https://developer.mozilla.org/en-US/docs/Web/API/InputEvent.isComposing
> https://developer.mozilla.org/en-US/docs/Web/API/InputEvent
> https://developer.mozilla.org/en-US/docs/Web/API/InputEvent.InputEvent
> and
> https://developer.mozilla.org/en-US/Firefox/Releases/31#Interfaces.2FAPIs.
> 2FDOM

Hmm, isComposing isn't a method. It's an attribute. See the spec.

	Jean-Yves Perrier [:teoli]
	Comment 10 • 9 years ago

Oopps. Fixed thanks.