Closed
Bug 993253
Opened 10 years ago
Closed 10 years ago
Implement D3E InputEvent interface with isComposing
Categories
(Core :: DOM: Events, defect)
Core
DOM: Events
Tracking
()
RESOLVED
FIXED
mozilla31
People
(Reporter: masayuki, Assigned: masayuki)
References
Details
(Keywords: dev-doc-complete)
Attachments
(1 file, 1 obsolete file)
34.75 KB,
patch
|
smaug
:
review+
ehsan.akhgari
:
review+
|
Details | Diff | Splinter Review |
D3E defines InputEvent interface. We should need to implement it. Currently, we cannot support .data without refactoring nsEditor. However, it's easy to implement isComposing attribute. So, let's implement only isComposing, first.
Assignee | ||
Comment 1•10 years ago
|
||
D3E defines InputEvent interface for "input" and "beforeinput". This patch implements InputEvent and exposes it to web contents. The initial InputEvent implementation only supports .isComposing. https://dvcs.w3.org/hg/dom3events/raw-file/tip/html/DOM3-Events.html#widl-InputEvent-isComposing > true if the input event occurs as part of a composition session, i.e., after a compositionstart event and before the corresponding compositionend event. > > The un-initialized value of this attribute MUST be false. Implementing the other attribute, .data, needs more work in editor. Therefore, I'd like to implement only .isComposing first. The internal event class is InternalEditorInputEvent since we already have WidgetInputEvent. So, InternalInputEvent isn't available with some macros. InputEvent doesn't support document.createEvent() but supports ctor. I'll request review to ehsan for the editor part.
Attachment #8403256 -
Flags: review?(bugs)
Comment 2•10 years ago
|
||
Comment on attachment 8403256 [details] [diff] [review] Implement DOM InputEvent interface with isComposing attribute + } + else { -> } else {
Attachment #8403256 -
Flags: review?(bugs) → review+
Assignee | ||
Comment 3•10 years ago
|
||
Rewriting the patch without creating nsIDOMInputEvent.
Attachment #8403256 -
Attachment is obsolete: true
Attachment #8403825 -
Flags: review?(bugs)
Updated•10 years ago
|
Attachment #8403825 -
Flags: review?(bugs) → review+
Assignee | ||
Comment 4•10 years ago
|
||
Comment on attachment 8403825 [details] [diff] [review] Implement DOM InputEvent interface with isComposing attribute Ehsan: Could you review the editor part? "input" event has specific internal event, InternalEditorInputEvent, by this patch. Therefore, editor needs to dispatch input events with its instance. It needs to take isComposing which is true after compositionstart and compositionend. Therefore, the dispatcher needs to the state at constructing rather than at dispatching the event actually.
Attachment #8403825 -
Flags: review?(ehsan)
Updated•10 years ago
|
Attachment #8403825 -
Flags: review?(ehsan) → review+
Updated•10 years ago
|
Keywords: dev-doc-needed
Assignee | ||
Comment 5•10 years ago
|
||
https://developer.mozilla.org/en-US/docs/Web/API/InputEvent I'll land the patches soon.
Assignee | ||
Comment 6•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/8a2a1efffcd5
Comment 7•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/8a2a1efffcd5
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla31
Comment 8•9 years ago
|
||
Doc updated (thanks :masayuki for the help here!) https://developer.mozilla.org/en-US/docs/Web/API/InputEvent.isComposing https://developer.mozilla.org/en-US/docs/Web/API/InputEvent https://developer.mozilla.org/en-US/docs/Web/API/InputEvent.InputEvent and https://developer.mozilla.org/en-US/Firefox/Releases/31#Interfaces.2FAPIs.2FDOM
Keywords: dev-doc-needed → dev-doc-complete
Assignee | ||
Comment 9•9 years ago
|
||
(In reply to Jean-Yves Perrier [:teoli] from comment #8) > Doc updated (thanks :masayuki for the help here!) > https://developer.mozilla.org/en-US/docs/Web/API/InputEvent.isComposing > https://developer.mozilla.org/en-US/docs/Web/API/InputEvent > https://developer.mozilla.org/en-US/docs/Web/API/InputEvent.InputEvent > and > https://developer.mozilla.org/en-US/Firefox/Releases/31#Interfaces.2FAPIs. > 2FDOM Hmm, isComposing isn't a method. It's an attribute. See the spec.
Comment 10•9 years ago
|
||
Oopps. Fixed thanks.
You need to log in
before you can comment on or make changes to this bug.
Description
•