Masayuki Nakano [:masayuki] (he/him)(JST, +0900) Assignee
	Description • 10 years ago

      No description provided.

	Masayuki Nakano [:masayuki] (he/him)(JST, +0900) Assignee
	Comment 1 • 10 years ago

https://dvcs.w3.org/hg/dom3events/raw-file/tip/html/DOM3-Events.html#widl-KeyboardEvent-isComposing

> true if the key event occurs as part of a composition session, i.e., after a compositionstart event and before the corresponding compositionend event.
> 
> The un-initialized value of this attribute MUST be false.

	Masayuki Nakano [:masayuki] (he/him)(JST, +0900) Assignee
	Comment 2 • 10 years ago

We can implement this bug very simply.

widget shouldn't set the isComposing value at dispatching key events. Instead of that, EventStateManager::PreHandleEvent() can do it.

	Masayuki Nakano [:masayuki] (he/him)(JST, +0900) Assignee
	Comment 3 • 10 years ago

Currently, dispatching key events during composition causes some assertions. Therefore, this patch adds |SimpleTest.expectAssertions(0, 16)|. Note that on Linux, the assertion doesn't occur. Therefore, it specifies 0-16.

	Olli Pettay [:smaug][bugs@pettay.fi]
	Comment 4 • 10 years ago

Comment on attachment 8403248 [details] [diff] [review]
part.1 Implement KeyboardEvent.isComposing

I wouldn't add isComposing to the .idl, nor 
KeyboardEvent::GetIsComposing.

New stuff can go to .webidl only, unless there is some good reason
to add to .idl too.

So, remove the .idl stuff, r=me

	Olli Pettay [:smaug][bugs@pettay.fi]
	Comment 5 • 10 years ago

Comment on attachment 8403251 [details] [diff] [review]
part.2 Add tests for KeyboardEvent.isComposing

I'd like to see at least some test for keypress too, at least to check that
it returns sane value, and not some random value for isComposing.

	Masayuki Nakano [:masayuki] (he/him)(JST, +0900) Assignee
	Comment 6 • 10 years ago

Thanks, then, this doesn't need sr.

	Masayuki Nakano [:masayuki] (he/him)(JST, +0900) Assignee
	Comment 7 • 10 years ago

Although, keypress event should never be fired during composition even if after bug 354358 is fixed. But it's okay to include the test for something wired case.

	Masayuki Nakano [:masayuki] (he/him)(JST, +0900) Assignee
	Comment 8 • 10 years ago

And I hope VK_INSERT will never be handled by our editor...

	Masayuki Nakano [:masayuki] (he/him)(JST, +0900) Assignee
	Comment 9 • 10 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/839bf025c534
https://hg.mozilla.org/integration/mozilla-inbound/rev/d40a8916b7e7

	Ryan VanderMeulen [:RyanVM]
	Comment 10 • 10 years ago

https://hg.mozilla.org/mozilla-central/rev/839bf025c534
https://hg.mozilla.org/mozilla-central/rev/d40a8916b7e7

	Jean-Yves Perrier [:teoli]
	Comment 11 • 9 years ago

Documented:
https://developer.mozilla.org/en-US/docs/Web/API/KeyboardEvent.isComposing
https://developer.mozilla.org/en-US/docs/Web/API/KeyboardEvent
and
https://developer.mozilla.org/en-US/Firefox/Releases/31#Interfaces.2FAPIs.2FDOM