Beatriz Rodríguez [:brg] Reporter
	Description • 10 years ago

This is a suggestion of strings improvement in English that provide information through MMI codes about the status of call barring service.

This is not a blocker in 1.3 but a nice improvement for the future if you agree.

1) Interrogation (*#33#)

1.A) If call barring is currently enabled:

Current English translation:  Service was enabled for:
Expected English translation: Service is enabled for:

1.B) If call barring is currently disabled:

Current English translation:  Service has been disabled
Expected English translation: Service is disabled

	Axel Hecht [:Pike]
	Comment 1 • 10 years ago

Moving over to fx os, this might be good input for the copy review.

	Guillermo López :willyaranda (probably SLOW response)
	Comment 2 • 10 years ago

Hi,

I was talking with Beatriz and the problem is that there is a single en-US string for two different actions here:

1) Query the operator what is the status of Call barring
2) Query the operator to CHANGE the status of Call barring

In both cases, if the service end up being deactivated, the English string is "Service has been disabled".

So, with my bad English, I think case 1) should something like "Service is disabled" and case 2) "Service has been disabled".

I don't know, but maybe it is the same for the enabled call barring status.

	Guillermo López :willyaranda (probably SLOW response)
	Comment 3 • 10 years ago

(BTW, the reference URL in transvision: http://transvision.mozfr.org/?recherche=Service+has+been+disabled&repo=gaia&sourcelocale=en-US&locale=es&search_type=strings)

	Matej Novak [:matej]
	Comment 4 • 10 years ago

(In reply to Axel Hecht [:Pike] from comment #1)
> Moving over to fx os, this might be good input for the copy review.

Thanks, Alex. Also CCing Stephany as she is leading the copy audit.

At a quick look, the proposal in comment 2 looks about right.

	Beatriz Rodríguez [:brg] Reporter
	Comment 5 • 10 years ago

Stephany, per comment 4, is there any chance that this change could be included in 2.0?

	Stephany Wilkes
	Comment 6 • 10 years ago

We are well past string freeze so likely not, unfortunately.

	David Garcia [:davidg][retired] Assignee
	Comment 7 • 10 years ago

Because the mmiResponse is exactly the same when you query and when you activate/deactivate the service, I'm passing the original mmi command to success handler, to be able to show one message or the other.
I was trying to include test, but the only thing to test is what text is displayed, and I'm not sure that kind of test makes sense.

	Etienne Segonzac (:etienne)
	Comment 8 • 10 years ago

Comment on attachment 8462467 [details] [review]
github PR

redirecting...

	Anthony Ricaud (:rik)
	Comment 9 • 10 years ago

Comment on attachment 8462467 [details] [review]
github PR

Re-redirecting to Doug. Doug: If you have doubts about MMI behaviours, please ask.

	Doug Sherk (:drs) (inactive)
	Comment 10 • 10 years ago

Comment on attachment 8462467 [details] [review]
github PR

I left some comments on the PR. This does need some tests to check that it displays the correct strings. I may have more significant changes after I talk with Gabriele and Anthony about this.

	Gabriele Svelto [:gsvelto]
	Comment 11 • 10 years ago

Moving this to the right component and marking it as assigned since work is undergoing already.

	David Garcia [:davidg][retired] Assignee
	Comment 12 • 10 years ago

Comment on attachment 8462467 [details] [review]
github PR

Sorted comments from Gsvelto and Doug.
Added some tests

	Doug Sherk (:drs) (inactive)
	Comment 13 • 10 years ago

Comment on attachment 8462467 [details] [review]
github PR

I left some comments on the PR.

Also, this could use a demo.

	Doug Sherk (:drs) (inactive)
	Comment 14 • 10 years ago

Comment on attachment 8462467 [details] [review]
github PR

Please refer to bug 1049651 in the TODO comment and then I think we're good to go.

	Doug Sherk (:drs) (inactive)
	Comment 15 • 10 years ago

Also, please update the title of this bug and the PR to better reflect what changes are actually being made.

	Fernando R. Sela (no CC, needinfo please) [:frsela]
	Comment 16 • 10 years ago

Landed: https://github.com/mozilla-b2g/gaia/commit/cc60e6582f74a96cbab1edb250fda6f7af8d8c86

	Loli (:lolimartinezcr)
	Comment 17 • 10 years ago

Tested and working
Flame 
2.1
Gecko-ca5d875
Gaia-fee004d

If call barring is currently enabled and I ask to device status: 
Service is enabled for: ...

If call barring is currently disabled and I ask to device status: 
Service is disabled