Closed Bug 987685 Opened 10 years ago Closed 8 years ago

Display the script sources in a collapsible folder tree rather than in a list

Categories

(DevTools :: Debugger, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED DUPLICATE of bug 1300861

People

(Reporter: pbro, Unassigned)

References

(Blocks 1 open bug)

Details

(Whiteboard: [polish-backlog][difficulty=medium])

I personally never use the script sources panel in the debugger simply because it's a flat list that displays all scripts.
This panel is especially difficult to use when I'm working on a site (or in the browser toolbox) with a lot of scripts loaded.

A folder tree structure with collapsible folders would make it a lot easier to use/browser around to find a given file (even if the search bar is great, some people just prefer locating a script by looking at the list).
Also, as a developer spending a fair amount of time in a text editor that has such a folder tree (like sublime), it just makes so much more sense to display the same kind of tree in the devtools.
Depends on: 970517
Depends on: 993014
No longer depends on: 970517
Please keep in mind source maps. Working with browserified code and source maps it creates a ton of node_modules files that I usually just want to blackbox. So ideally, there should be collapsible folder tree with the possibility to blackbox the entire folder.
Whiteboard: [polish-backlog][difficulty=medium]
I'm skeptical of difficulty-medium, personally, give #c2.
Blackboxing an entire folder at a time is clearly a different feature and separate from making the sources a tree instead of a list.

Also, bug 1208131 to automatically black box node_modules.
Can we do something much simpler here, and just sort the list alphabetically?  This has been unusable for months; let's postpone doing hard things and just try to make it a little better.
(In reply to Nick Alexander :nalexander from comment #5)
> Can we do something much simpler here, and just sort the list
> alphabetically?  This has been unusable for months; let's postpone doing
> hard things and just try to make it a little better.

That is also a good idea!  See bug 883702 for this specific thing.
This feature is DESPERATELY needed.  In addition, both the FF Dev Tools and Firebug need to implement having a separate "Breakpoints" sub-tab, as in Firebug2 and Chrome Dev Tools, as opposed to having them inline in the scripts list.  Frankly, the current FF Dev Tools are effectively unusable for debugging with the current UI.
(In reply to Mark Erikson from comment #7)
> This feature is DESPERATELY needed.  In addition, both the FF Dev Tools and
> Firebug need to implement having a separate "Breakpoints" sub-tab, as in
> Firebug2 and Chrome Dev Tools, as opposed to having them inline in the
> scripts list.  Frankly, the current FF Dev Tools are effectively unusable
> for debugging with the current UI.

I agree. I also think that having a tree view would be one of the most important steps towards getting worker debugging production ready (the main thread can have workers, workers can have sub workers, and all of these can have sources, so a tree view is just the most natural way to display all these).

I would like to push to make this feature a priority for Q1. James, what is your opinion on this? I am not strong on frontend code myself, so you would be the most obvious person to work on this. Now that your big refactor has landed, do you have any other big projects going on?
Flags: needinfo?(jlong)
(In reply to Eddy Bruel [:ejpbruel] from comment #8)

> I would like to push to make this feature a priority for Q1. James, what is
> your opinion on this? I am not strong on frontend code myself, so you would
> be the most obvious person to work on this. Now that your big refactor has
> landed, do you have any other big projects going on?

I've said for a while that two major deficiencies in our current tools are:

1. No sourcemaps in the console, and
2. A flat list of sources

So those are my two projects :)

I'm working more actively on #1 right now because I'm about to land an important patch to enable it (bug 1132501).

This specific request was actually a big motivation for the debugger refactor; we literally couldn't change something like the sources pane without updating almost everything else, because everything was getting the source state from the sources pane.

The good news is that my refactor definitely makes this a realistic Q1 goal. This also lines up well with Jordan and Victor's desire to write some standardized UI components in React; I can help write a tree view (or polish up whatever we have).

So yes: our current sources view is embarrassing, and making it a Q1 goal would be great. I'm not sure how realistic it is to actually land a tree view, but we could probably get most of the way there. Changing this tends to lead to a design refactor: we'll have to move the breakpoints somewhere else, etc.
Flags: needinfo?(jlong)
The newly-enabled debugger front-end (debugger.html) has no such problem.
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → DUPLICATE
Product: Firefox → DevTools
Blocks: 1565711
Blocks: 1565713
No longer blocks: 1565711
No longer blocks: 1565713
You need to log in before you can comment on or make changes to this bug.