Closed
Bug 977893
Opened 10 years ago
Closed 10 years ago
getCurrentUrl does not match behaviour of the WebDriver spec
Categories
(Remote Protocol :: Marionette, defect, P3)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla35
People
(Reporter: automatedtester, Assigned: automatedtester)
References
(Blocks 1 open bug, )
Details
(Keywords: pi-marionette-spec)
Attachments
(2 files, 2 obsolete files)
3.43 KB,
patch
|
Details | Diff | Splinter Review | |
13.15 KB,
patch
|
jgriffin
:
review+
|
Details | Diff | Splinter Review |
when calling getCurrentUrl we must return the top level browsing context url not the url of the current frame.
Updated•10 years ago
|
Assignee: nobody → ato
Status: NEW → ASSIGNED
Comment 1•10 years ago
|
||
Attaching a first stab at a fix for this. I'm not sure how to reliably access the parent frame of cross-domain documents. Can we override the security permissions imposed by the DOM somehow?
Attachment #8392933 -
Flags: review?(dburns)
Assignee | ||
Updated•10 years ago
|
Attachment #8392933 -
Flags: review?(dburns) → feedback?(dburns)
Assignee | ||
Comment 2•10 years ago
|
||
Assignee | ||
Updated•10 years ago
|
Assignee: ato → dburns
Assignee | ||
Comment 3•10 years ago
|
||
To get the top level context we need to work mainly in the server code. I have half done the patch, it will need more testing I would make sure we test on b2g because this may have unforeseen circumstances...
Assignee: dburns → ato
Comment 4•10 years ago
|
||
That approach looks more sane to me, thanks!
Assignee | ||
Updated•10 years ago
|
Attachment #8392933 -
Flags: feedback?(dburns)
Assignee | ||
Updated•10 years ago
|
Whiteboard: [spec]
Assignee | ||
Updated•10 years ago
|
Keywords: ateam-marionette-spec
Assignee | ||
Updated•10 years ago
|
Priority: -- → P3
Updated•10 years ago
|
Whiteboard: [spec]
Comment 5•10 years ago
|
||
It looks like patch attached by David Burns is already in master branch. Should it be closed?
Comment 6•10 years ago
|
||
Sorry, I misunderstood the diff.
Assignee | ||
Comment 7•10 years ago
|
||
https://tbpl.mozilla.org/?tree=Try&rev=d01a09d8cace
Assignee | ||
Comment 8•10 years ago
|
||
https://tbpl.mozilla.org/?tree=Try&rev=2255f80e1cd8
Assignee | ||
Comment 9•10 years ago
|
||
https://tbpl.mozilla.org/?tree=Try&rev=ff3a0f95e6e9
Assignee | ||
Updated•10 years ago
|
Assignee: ato → dburns
Assignee | ||
Comment 10•10 years ago
|
||
Assignee | ||
Updated•10 years ago
|
Attachment #8393227 -
Attachment is obsolete: true
Assignee | ||
Comment 11•10 years ago
|
||
https://tbpl.mozilla.org/?tree=Try&rev=dfb52410cffd
Assignee | ||
Comment 12•10 years ago
|
||
https://tbpl.mozilla.org/?tree=Try&rev=7390654cd1f2
Assignee | ||
Comment 13•10 years ago
|
||
https://tbpl.mozilla.org/?tree=Try&rev=da912b014d67
Assignee | ||
Comment 14•10 years ago
|
||
https://tbpl.mozilla.org/?tree=Try&rev=4909e98539f8
Assignee | ||
Comment 15•10 years ago
|
||
Attachment #8483727 -
Flags: review?(jgriffin)
Assignee | ||
Updated•10 years ago
|
Attachment #8477783 -
Attachment is obsolete: true
Comment 16•10 years ago
|
||
Comment on attachment 8483727 [details] [diff] [review] getCurrentUrl in marionette should return the url for the top level document Review of attachment 8483727 [details] [diff] [review]: ----------------------------------------------------------------- I'm a little sad about disabling test_switch_frame on b2g, but I guess that kind of in-process frame switching isn't common there (or maybe never exists at all).
Attachment #8483727 -
Flags: review?(jgriffin) → review+
Assignee | ||
Comment 17•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/1d1bca9ca7a3
Comment 18•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/1d1bca9ca7a3
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
Updated•1 year ago
|
Product: Testing → Remote Protocol
You need to log in
before you can comment on or make changes to this bug.
Description
•