Closed
Bug 974891
Opened 10 years ago
Closed 10 years ago
Move TestCapabilities to test_capabilities.py file
Categories
(Remote Protocol :: Marionette, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla30
People
(Reporter: ato, Assigned: mishravikas)
Details
Attachments
(1 file, 2 obsolete files)
7.11 KB,
patch
|
ato
:
review+
|
Details | Diff | Splinter Review |
The TestCapabilities class currently sits in test_session.py. It should be moved to test_capabilities.py for consistency.
Assignee | ||
Comment 1•10 years ago
|
||
I would like to work in this bug
Reporter | ||
Comment 2•10 years ago
|
||
Excellent! There is already a test in test_capabilities.py, but this is superseded by the more mature tests from the TestCapabilities class in test_session.py.
Assignee | ||
Comment 3•10 years ago
|
||
Moved TestCapabilities class to test_capabilities.py
Attachment #8391256 -
Flags: review?
Reporter | ||
Updated•10 years ago
|
Attachment #8391256 -
Flags: review? → review?(ato)
Updated•10 years ago
|
Assignee: nobody → vikasmishra95
Assignee | ||
Comment 4•10 years ago
|
||
Attachment #8391338 -
Flags: review?(jgriffin)
Updated•10 years ago
|
Attachment #8391338 -
Flags: review?(jgriffin) → review?(ato)
Updated•10 years ago
|
Attachment #8391256 -
Attachment is obsolete: true
Attachment #8391256 -
Flags: review?(ato)
Reporter | ||
Comment 5•10 years ago
|
||
Comment on attachment 8391338 [details] [diff] [review] New Patch This is good, thanks! If you have the time, would you please also add test_capabilities.py to testing/marionette/client/marionette_tests/unit/unit-tests.ini? It seems to be missing from there.
Attachment #8391338 -
Flags: review?(ato) → review+
Flags: needinfo?(vikasmishra95)
Assignee | ||
Comment 6•10 years ago
|
||
Attachment #8391391 -
Flags: review?(ato)
Flags: needinfo?(vikasmishra95)
Reporter | ||
Comment 7•10 years ago
|
||
Comment on attachment 8391391 [details] [diff] [review] New Patch with mentioned changes Review of attachment 8391391 [details] [diff] [review]: ----------------------------------------------------------------- Perfect, thanks!
Attachment #8391391 -
Flags: review?(ato) → review+
Assignee | ||
Updated•10 years ago
|
Keywords: checkin-needed
Updated•10 years ago
|
Attachment #8391338 -
Attachment is obsolete: true
Comment 8•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/a94de1fe002c
Flags: in-testsuite+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/a94de1fe002c
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
Updated•1 year ago
|
Product: Testing → Remote Protocol
You need to log in
before you can comment on or make changes to this bug.
Description
•