Closed Bug 974403 Opened 10 years ago Closed 9 years ago

AttributeError: "'NoneType' object has no attribute 'Popen'" in <bound method Process.__del__ of <mozprocess.processhandler.Process object at 0x23f4f90>>

Categories

(Testing :: Mozbase, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED WORKSFORME

People

(Reporter: ato, Unassigned)

Details

When running any Marionette test through testing/marionette/client/marionette/runtests.py this gets appended to the text suite runner from unittest:

Exception in thread Thread-2:
Traceback (most recent call last):
  File "/usr/lib/python2.7/threading.py", line 808, in __bootstrap_inner
    self.run()
  File "/usr/lib/python2.7/threading.py", line 761, in run
    self.__target(*self.__args, **self.__kwargs)
  File "/home/ato/Code/marionette/local/lib/python2.7/site-packages/mozprocess-0.15-py2.7.egg/mozprocess/processhandler.py", line 729, in _processOutput
    (lines, self.didTimeout) = self.readWithTimeout(logsource, lineReadTimeout)
  File "/home/ato/Code/marionette/local/lib/python2.7/site-packages/mozprocess-0.15-py2.7.egg/mozprocess/processhandler.py", line 681, in readWithTimeout
    return self._readWithTimeout(f, timeout)
  File "/home/ato/Code/marionette/local/lib/python2.7/site-packages/mozprocess-0.15-py2.7.egg/mozprocess/processhandler.py", line 820, in _readWithTimeout
    output = os.read(f.fileno(), 4096)
AttributeError: 'NoneType' object has no attribute 'read'

Exception AttributeError: "'NoneType' object has no attribute 'Popen'" in <bound method Process.__del__ of <mozprocess.processhandler.Process object at 0x23f4f90>> ignored
With bug 794984, we removed the _readWithTimeout method. So there is no way we can get this stacktrace again.

If I look at the Process.__del__ method now, it just call the parent __del__ method (for non windows, and reading at the stacktrace above this is a no windows error): https://dxr.mozilla.org/mozilla-central/source/testing/mozbase/mozprocess/mozprocess/processhandler.py#119.

I suggest that we close this bug, and maybe reopen it with an accurate stack trace if an error like this happen again.
Flags: needinfo?(ahalberstadt)
Are you still able to reproduce this? If so, is the error message different now? If not let's close WFM.
Flags: needinfo?(ahalberstadt) → needinfo?(ato)
I haven't seen this in a while.  Closing.
Status: NEW → RESOLVED
Closed: 9 years ago
Flags: needinfo?(ato)
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.