Closed
Bug 964367
Opened 10 years ago
Closed 10 years ago
Capability platformName offered by Marionette is incorrect
Categories
(Remote Protocol :: Marionette, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla30
People
(Reporter: ato, Assigned: ato)
References
(Blocks 1 open bug, )
Details
Attachments
(1 file)
6.43 KB,
patch
|
mdas
:
review+
|
Details | Diff | Splinter Review |
The capability platformName that's returned on the creation of a new session in Marionette through newSession is incorrectly formatted. One of the following values is expected on desktop: ANDROID IOS LINUX MAC UNIX WINDOWS ANY The following is returned on Linux: Linux So for desktop this should be a matter of upper-casing the string. On Firefox OS we should use "MOZ-FIREFOXOS" as suggested by the WebDriver specification, which could eventually deprecate the "b2g" capability.
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → ato
Status: NEW → ASSIGNED
Assignee | ||
Comment 1•10 years ago
|
||
try: https://tbpl.mozilla.org/?tree=Try&rev=9df3aef7cc25
Attachment #8371590 -
Flags: review?(mdas)
Assignee | ||
Comment 2•10 years ago
|
||
Tip of inbound is busted, will wait and trigger a new try run once inbound has been fixed.
Assignee | ||
Comment 3•10 years ago
|
||
New try based on central: https://tbpl.mozilla.org/?tree=Try&rev=e33ab53723ef
Comment 4•10 years ago
|
||
Comment on attachment 8371590 [details] [diff] [review] 0001-Bug-964367-Fix-incorrect-format-on-platformName-capa.patch Review of attachment 8371590 [details] [diff] [review]: ----------------------------------------------------------------- ::: testing/marionette/marionette-server.js @@ +574,5 @@ > + // Proprietary extensions > + "XULappId" : Services.appinfo.ID, > + "appBuildId" : Services.appinfo.appBuildID, > + "device": qemu == "1" ? "qemu" : (!device ? "desktop" : device), > + "version": Services.appinfo.version I like the categorization, it's much easier to read now, thanks!
Attachment #8371590 -
Flags: review?(mdas) → review+
Assignee | ||
Updated•10 years ago
|
Keywords: checkin-needed
Comment 5•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/76cb0c973a15
Flags: in-testsuite+
Keywords: checkin-needed
Comment 6•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/76cb0c973a15
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
Assignee | ||
Comment 7•10 years ago
|
||
Thanks for the pointer, and I'm glad to see jgriffin uplifted it. It's really difficult to spot these incompatibilities because they don't trigger any test errors in try…
Updated•1 year ago
|
Product: Testing → Remote Protocol
You need to log in
before you can comment on or make changes to this bug.
Description
•