Closed
Bug 963598
Opened 10 years ago
Closed 10 years ago
until method does not take a custom message
Categories
(Remote Protocol :: Marionette, defect)
Tracking
(b2g-v1.3 fixed)
RESOLVED
FIXED
mozilla29
| Tracking | Status | |
|---|---|---|
| b2g-v1.3 | --- | fixed |
People
(Reporter: zcampbell, Assigned: ato)
References
Details
Attachments
(1 file)
|
5.91 KB,
patch
|
davehunt
:
review+
|
Details | Diff | Splinter Review |
The Wait class's until method does not take a custom failure message. Selenium2's does. When using obtuse conditions in the Wait class the default failure message can be quite vague so overriding it is beneficial for debugging.
|
Assignee | |
Comment 1•10 years ago
|
||
That makes sense. It's great to hear the use cases.
Assignee: nobody → ato
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 2•10 years ago
|
||
try: https://tbpl.mozilla.org/?tree=Try&rev=f1ad261a2d34
Attachment #8365959 -
Flags: review?(zcampbell)
|
||
Comment 3•10 years ago
|
||
Comment on attachment 8365959 [details] [diff] [review] 0001-Bug-963598-Allow-custom-message-when-Wait.until-time.patch Review of attachment 8365959 [details] [diff] [review]: ----------------------------------------------------------------- Stealing this review as it's blocking the release. Looks great, thanks Andreas!
Attachment #8365959 -
Flags: review?(zcampbell) → review+
|
|
Assignee | |
Updated•10 years ago
|
Keywords: checkin-needed
|
||
Comment 4•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/499a39c0e2ad
Flags: in-testsuite+
Keywords: checkin-needed
|
||
Comment 5•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/499a39c0e2ad
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
|
||
Updated•10 years ago
|
status-b2g-v1.3:
--- → fixed
|
||
Updated•1 year ago
|
Product: Testing → Remote Protocol
You need to log in
before you can comment on or make changes to this bug.
Description
•