Closed
Bug 959820
Opened 10 years ago
Closed 10 years ago
Rename drawSystemFocusRing to drawFocusIfNeeded
Categories
(Core :: Graphics: Canvas2D, defect)
Core
Graphics: Canvas2D
Tracking
()
RESOLVED
FIXED
mozilla29
People
(Reporter: cabanier, Assigned: cabanier)
References
Details
(Keywords: access, dev-doc-complete, html5)
Attachments
(1 file)
8.17 KB,
patch
|
roc
:
review+
|
Details | Diff | Splinter Review |
The HTML A11y group decided to rename drawSystemFocusRing to drawFocusIfNeeded since it is less confusing.
Assignee | ||
Updated•10 years ago
|
Assignee | ||
Comment 1•10 years ago
|
||
Try run: https://tbpl.mozilla.org/?tree=Try&rev=0d606c9e0eeb
Attachment #8360152 -
Flags: review?(roc)
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → cabanier
Comment on attachment 8360152 [details] [diff] [review] Renamed idl + impl + test files Review of attachment 8360152 [details] [diff] [review]: ----------------------------------------------------------------- Thanks!
Attachment #8360152 -
Flags: review?(roc) → review+
By the way, should we remove drawCustomFocusRing? It seems the name and/or behavior are likely to change and it won't be standardized for some time.
Assignee | ||
Comment 4•10 years ago
|
||
(In reply to Robert O'Callahan (:roc) (Mozilla Corporation) from comment #3) > By the way, should we remove drawCustomFocusRing? It seems the name and/or > behavior are likely to change and it won't be standardized for some time. I was planning on leaving it behind the runtime flag for now. Maybe it's better to remove it since it is not going to be adopted? If you think so, I will create a bug to remove it.
Assignee | ||
Updated•10 years ago
|
Attachment #8360152 -
Flags: checkin?(ryanvm)
Maybe it should have its own runtime flag. We probably should enable drawFocusIfNeeded before drawCustomFocusRing.
Assignee | ||
Comment 6•10 years ago
|
||
(In reply to Robert O'Callahan (:roc) (Mozilla Corporation) from comment #5) > Maybe it should have its own runtime flag. We probably should enable > drawFocusIfNeeded before drawCustomFocusRing. OK. I will introduce a new flag for customfocusring.
Updated•10 years ago
|
Attachment #8360152 -
Flags: checkin?(ryanvm)
Updated•10 years ago
|
Keywords: checkin-needed
Comment 7•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/81e542a2ab70
Flags: in-testsuite+
Keywords: checkin-needed
Comment 8•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/81e542a2ab70
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
Comment 9•9 years ago
|
||
https://developer.mozilla.org/en-US/Firefox/Releases/29#Interfaces.2FAPIs.2FDOM https://developer.mozilla.org/en-US/docs/Web/API/CanvasRenderingContext2D.drawFocusIfNeeded
Keywords: dev-doc-complete
You need to log in
before you can comment on or make changes to this bug.
Description
•