Closed
Bug 957162
Opened 10 years ago
Closed 10 years ago
Marionette waits should include the timeout duration when throwing TimeoutException
Categories
(Remote Protocol :: Marionette, defect)
Remote Protocol
Marionette
Tracking
(firefox27 fixed, firefox28 fixed, firefox29 fixed)
RESOLVED
FIXED
mozilla29
People
(Reporter: davehunt, Assigned: ato)
Details
Attachments
(1 file)
2.62 KB,
patch
|
davehunt
:
review+
|
Details | Diff | Splinter Review |
Currently if a Wait fails a TimeoutException is thrown with no message: TEST-UNEXPECTED-FAIL | test_homescreen_edit_mode.py test_homescreen_edit_mode.TestEditMode.test_access_and_leave_edit_mode | TimeoutException: None We should at least include the timeout duration: TEST-UNEXPECTED-FAIL | test_homescreen_edit_mode.py test_homescreen_edit_mode.TestEditMode.test_access_and_leave_edit_mode | TimeoutException: Timed out after 0.1 seconds This can be a useful indication when looking at failures that an inappropriate timeout value is being used.
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → ato
Status: NEW → ASSIGNED
Reporter | ||
Updated•10 years ago
|
Attachment #8357185 -
Flags: review?(dave.hunt) → review+
Assignee | ||
Updated•10 years ago
|
Keywords: checkin-needed
Comment 2•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/ed17bd48a68b
Flags: in-testsuite+
Keywords: checkin-needed
Comment 3•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/ed17bd48a68b
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
Comment 4•10 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/7ef86ccc40c5 https://hg.mozilla.org/releases/mozilla-beta/rev/5931195ee957 https://hg.mozilla.org/releases/mozilla-b2g26_v1_2/rev/c48a12b43fd3
status-b2g-v1.2:
--- → fixed
status-firefox27:
--- → fixed
status-firefox28:
--- → fixed
status-firefox29:
--- → fixed
Comment 5•10 years ago
|
||
I pressed my luck a bit too much on this. Backed out from b2g26 for test failures that I've already gone too far down the rabbit hole trying to fix. https://hg.mozilla.org/releases/mozilla-b2g26_v1_2/rev/b01ca2847626
status-b2g-v1.2:
fixed → ---
Updated•1 year ago
|
Product: Testing → Remote Protocol
You need to log in
before you can comment on or make changes to this bug.
Description
•