Closed
Bug 952977
Opened 10 years ago
Closed 10 years ago
Switch some uses of gfx3DMatrix to gfx::Matrix4x4
Categories
(Core :: Graphics, defect)
Core
Graphics
Tracking
()
RESOLVED
FIXED
People
(Reporter: dzbarsky, Assigned: dzbarsky)
References
Details
Attachments
(55 files, 2 obsolete files)
No description provided.
Assignee | ||
Comment 1•10 years ago
|
||
Assignee: nobody → dzbarsky
Status: NEW → ASSIGNED
Attachment #8351250 -
Flags: review?(nical.bugzilla)
Assignee | ||
Comment 2•10 years ago
|
||
Attachment #8351255 -
Flags: review?(nical.bugzilla)
Updated•10 years ago
|
Attachment #8351250 -
Flags: review?(nical.bugzilla) → review+
Updated•10 years ago
|
Attachment #8351255 -
Flags: review?(nical.bugzilla) → review+
Assignee | ||
Comment 3•10 years ago
|
||
Assignee | ||
Updated•10 years ago
|
Attachment #8351268 -
Attachment is patch: true
Attachment #8351268 -
Attachment mime type: message/rfc822 → text/plain
Attachment #8351268 -
Flags: review?(nical.bugzilla)
Assignee | ||
Comment 4•10 years ago
|
||
Attachment #8351386 -
Flags: review?(nical.bugzilla)
Assignee | ||
Comment 5•10 years ago
|
||
Attachment #8351387 -
Flags: review?(nical.bugzilla)
Assignee | ||
Comment 6•10 years ago
|
||
Attachment #8351388 -
Flags: review?(nical.bugzilla)
Assignee | ||
Comment 7•10 years ago
|
||
Attachment #8351389 -
Flags: review?(nical.bugzilla)
Assignee | ||
Comment 8•10 years ago
|
||
Attachment #8351391 -
Flags: review?(nical.bugzilla)
Assignee | ||
Comment 9•10 years ago
|
||
Attachment #8351392 -
Flags: review?(nical.bugzilla)
Assignee | ||
Comment 10•10 years ago
|
||
Attachment #8351393 -
Flags: review?(nical.bugzilla)
Comment 11•10 years ago
|
||
Comment on attachment 8351268 [details] [diff] [review] GetCanvasTM and friends Review of attachment 8351268 [details] [diff] [review]: ----------------------------------------------------------------- ::: layout/svg/SVGTextFrame.cpp @@ +3575,3 @@ > mRect.y / appUnitsPerDevPixel, > mRect.width / appUnitsPerDevPixel, > mRect.height / appUnitsPerDevPixel); ultra lame nit: indentation is off
Attachment #8351268 -
Flags: review?(nical.bugzilla) → review+
Assignee | ||
Comment 12•10 years ago
|
||
Looks like we used to set the world transform to this matrix when using OpenGL layers, but now we have AsyncCompositionManager::ComputeRotation()
Attachment #8351416 -
Flags: review?(mwu)
Assignee | ||
Comment 13•10 years ago
|
||
Attachment #8351425 -
Flags: review?(nical.bugzilla)
Assignee | ||
Comment 14•10 years ago
|
||
Attachment #8351426 -
Flags: review?(nical.bugzilla)
Assignee | ||
Comment 15•10 years ago
|
||
Attachment #8351427 -
Flags: review?(nical.bugzilla)
Assignee | ||
Comment 16•10 years ago
|
||
Attachment #8351428 -
Flags: review?(nical.bugzilla)
Assignee | ||
Comment 17•10 years ago
|
||
Attachment #8351429 -
Flags: review?(nical.bugzilla)
Assignee | ||
Comment 18•10 years ago
|
||
Attachment #8351430 -
Flags: review?(nical.bugzilla)
Updated•10 years ago
|
Attachment #8351416 -
Flags: review?(mwu) → review+
Assignee | ||
Comment 19•10 years ago
|
||
Try run here: https://tbpl.mozilla.org/?tree=Try&rev=5c43a1024d8e The linux failures start with the GetCanvasTM patch, but there's no platform-specific code there. Perhaps it has something to do with deprecated textures?
Flags: needinfo?(nical.bugzilla)
Assignee | ||
Comment 20•10 years ago
|
||
I built on linux locally with clang and couldn't reproduce it, so it could also potentially be a float/double gcc compiler bug.
Assignee | ||
Comment 21•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/4ce43cb764d5 https://hg.mozilla.org/integration/mozilla-inbound/rev/b04bd18e5692 https://hg.mozilla.org/integration/mozilla-inbound/rev/4a2a444ec574
Whiteboard: [leave open]
Assignee | ||
Comment 22•10 years ago
|
||
Backed out PrependSVG https://hg.mozilla.org/integration/mozilla-inbound/rev/8eacfa0523bd
Comment 23•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/4ce43cb764d5 https://hg.mozilla.org/mozilla-central/rev/4a2a444ec574
Updated•10 years ago
|
Attachment #8351386 -
Flags: review?(nical.bugzilla) → review+
Updated•10 years ago
|
Attachment #8351387 -
Flags: review?(nical.bugzilla) → review+
Updated•10 years ago
|
Attachment #8351388 -
Flags: review?(nical.bugzilla) → review+
Updated•10 years ago
|
Attachment #8351389 -
Flags: review?(nical.bugzilla) → review+
Updated•10 years ago
|
Attachment #8351391 -
Flags: review?(nical.bugzilla) → review+
Updated•10 years ago
|
Attachment #8351392 -
Flags: review?(nical.bugzilla) → review+
Updated•10 years ago
|
Attachment #8351393 -
Flags: review?(nical.bugzilla) → review+
Updated•10 years ago
|
Attachment #8351425 -
Flags: review?(nical.bugzilla) → review+
Updated•10 years ago
|
Attachment #8351426 -
Flags: review?(nical.bugzilla) → review+
Updated•10 years ago
|
Attachment #8351427 -
Flags: review?(nical.bugzilla) → review+
Comment 25•10 years ago
|
||
(In reply to David Zbarsky (:dzbarsky) from comment #19) > Try run here: > https://tbpl.mozilla.org/?tree=Try&rev=5c43a1024d8e > > The linux failures start with the GetCanvasTM patch, but there's no > platform-specific code there. Perhaps it has something to do with > deprecated textures? Deprecated/new textures are an OMTC-only thing, so unless you forced OMTC and GL layers I don't think it is related.
Flags: needinfo?(nical.bugzilla)
Assignee | ||
Comment 26•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/f29ac8c53779 https://hg.mozilla.org/integration/mozilla-inbound/rev/983b63dc75e3 https://hg.mozilla.org/integration/mozilla-inbound/rev/8821d96ad478
Can we do something to prevent dropping mozilla::gfx:: prefixes all over the place? Perhaps add a "typedef mozilla::gfx::Matrix Matrix;" to nsIFrame.h?
Assignee | ||
Comment 28•10 years ago
|
||
(In reply to Robert O'Callahan (:roc) (Mozilla Corporation) from comment #27) > Can we do something to prevent dropping mozilla::gfx:: prefixes all over the > place? Perhaps add a "typedef mozilla::gfx::Matrix Matrix;" to nsIFrame.h? I added that in this push. https://hg.mozilla.org/integration/mozilla-inbound/rev/4b412a92a92c https://hg.mozilla.org/integration/mozilla-inbound/rev/19983d377f58 https://hg.mozilla.org/integration/mozilla-inbound/rev/0f2c1da63eeb
Assignee | ||
Comment 29•10 years ago
|
||
Attachment #8354702 -
Flags: review?(nical.bugzilla)
Assignee | ||
Comment 30•10 years ago
|
||
Attachment #8354704 -
Flags: review?(nical.bugzilla)
Assignee | ||
Comment 31•10 years ago
|
||
Attachment #8354705 -
Flags: review?(nical.bugzilla)
Assignee | ||
Comment 32•10 years ago
|
||
Attachment #8354707 -
Flags: review?(nical.bugzilla)
Assignee | ||
Comment 33•10 years ago
|
||
Attachment #8354710 -
Flags: review?(nical.bugzilla)
Assignee | ||
Comment 34•10 years ago
|
||
Attachment #8354713 -
Flags: review?(nical.bugzilla)
Assignee | ||
Comment 35•10 years ago
|
||
Attachment #8354716 -
Flags: review?(nical.bugzilla)
Assignee | ||
Comment 36•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/3cf7d0ef7869 https://hg.mozilla.org/integration/mozilla-inbound/rev/f8e39fa87ba3
Comment 37•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/f29ac8c53779 https://hg.mozilla.org/mozilla-central/rev/983b63dc75e3 https://hg.mozilla.org/mozilla-central/rev/8821d96ad478 https://hg.mozilla.org/mozilla-central/rev/4b412a92a92c https://hg.mozilla.org/mozilla-central/rev/19983d377f58 https://hg.mozilla.org/mozilla-central/rev/0f2c1da63eeb https://hg.mozilla.org/mozilla-central/rev/7fb529b7829a https://hg.mozilla.org/mozilla-central/rev/3cf7d0ef7869 https://hg.mozilla.org/mozilla-central/rev/f8e39fa87ba3
Updated•10 years ago
|
Attachment #8351428 -
Flags: review?(nical.bugzilla) → review+
Updated•10 years ago
|
Attachment #8351429 -
Flags: review?(nical.bugzilla) → review+
Updated•10 years ago
|
Attachment #8354702 -
Flags: review?(nical.bugzilla) → review+
Updated•10 years ago
|
Attachment #8354704 -
Flags: review?(nical.bugzilla) → review+
Updated•10 years ago
|
Attachment #8354705 -
Flags: review?(nical.bugzilla) → review+
Updated•10 years ago
|
Attachment #8354707 -
Flags: review?(nical.bugzilla) → review+
Updated•10 years ago
|
Attachment #8354710 -
Flags: review?(nical.bugzilla) → review+
Assignee | ||
Comment 38•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/1a8e09381a51
Updated•10 years ago
|
Attachment #8354713 -
Flags: review?(nical.bugzilla) → review+
Updated•10 years ago
|
Attachment #8354716 -
Flags: review?(nical.bugzilla) → review+
Updated•10 years ago
|
Attachment #8351430 -
Flags: review?(nical.bugzilla) → review+
Assignee | ||
Comment 40•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/5f9f55f174e7
Assignee | ||
Comment 42•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/b15232e11c19
Assignee | ||
Comment 44•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/a0fd2401968c
Assignee | ||
Comment 46•10 years ago
|
||
Attachment #8363698 -
Flags: review?(nical.bugzilla)
Updated•10 years ago
|
Attachment #8363698 -
Flags: review?(nical.bugzilla) → review+
Assignee | ||
Comment 47•10 years ago
|
||
Attachment #8363848 -
Flags: review?(nical.bugzilla)
Updated•10 years ago
|
Attachment #8363848 -
Flags: review?(nical.bugzilla) → review+
Assignee | ||
Comment 48•10 years ago
|
||
Attachment #8365095 -
Flags: review?(nical.bugzilla)
Assignee | ||
Comment 49•10 years ago
|
||
Attachment #8365097 -
Flags: review?(nical.bugzilla)
Assignee | ||
Comment 50•10 years ago
|
||
Attachment #8365098 -
Flags: review?(nical.bugzilla)
Assignee | ||
Comment 51•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/1aed8b03154a https://hg.mozilla.org/integration/mozilla-inbound/rev/87b0be26bea9
Assignee | ||
Comment 52•10 years ago
|
||
Attachment #8365467 -
Flags: review?(nical.bugzilla)
Assignee | ||
Comment 53•10 years ago
|
||
Attachment #8365468 -
Flags: review?(nical.bugzilla)
Assignee | ||
Comment 54•10 years ago
|
||
Attachment #8365469 -
Flags: review?(nical.bugzilla)
Assignee | ||
Comment 55•10 years ago
|
||
Attachment #8365470 -
Flags: review?(nical.bugzilla)
Comment 56•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/1aed8b03154a https://hg.mozilla.org/mozilla-central/rev/87b0be26bea9
Assignee | ||
Comment 57•10 years ago
|
||
Attachment #8365705 -
Flags: review?(nical.bugzilla)
Assignee | ||
Comment 58•10 years ago
|
||
Attachment #8365729 -
Flags: review?(nical.bugzilla)
Assignee | ||
Comment 59•10 years ago
|
||
Attachment #8365730 -
Flags: review?(nical.bugzilla)
Assignee | ||
Comment 60•10 years ago
|
||
Attachment #8365731 -
Flags: review?(nical.bugzilla)
Assignee | ||
Comment 61•10 years ago
|
||
Attachment #8365732 -
Flags: review?(nical.bugzilla)
Assignee | ||
Comment 62•10 years ago
|
||
Attachment #8365733 -
Flags: review?(nical.bugzilla)
Assignee | ||
Comment 63•10 years ago
|
||
Attachment #8365734 -
Flags: review?(nical.bugzilla)
Updated•10 years ago
|
Attachment #8365095 -
Flags: review?(nical.bugzilla) → review+
Updated•10 years ago
|
Attachment #8365097 -
Flags: review?(nical.bugzilla) → review+
Comment 64•10 years ago
|
||
Comment on attachment 8365098 [details] [diff] [review] GetLocalTransform Review of attachment 8365098 [details] [diff] [review]: ----------------------------------------------------------------- ::: gfx/2d/Matrix.h @@ +284,5 @@ > > return Matrix(_11, _12, _21, _22, _41, _42); > } > > + bool CanDraw2D(Matrix* aMatrix = nullptr) const { Please add doc comments (as a followup if you want) to the new methods (especially when the abundance of existing Is2D, To2D, etc. make method names like this one not obvious).
Attachment #8365098 -
Flags: review?(nical.bugzilla) → review+
Updated•10 years ago
|
Attachment #8365467 -
Flags: review?(nical.bugzilla) → review+
Updated•10 years ago
|
Attachment #8365468 -
Flags: review?(nical.bugzilla) → review+
Updated•10 years ago
|
Attachment #8365469 -
Flags: review?(nical.bugzilla) → review+
Updated•10 years ago
|
Attachment #8365470 -
Flags: review?(nical.bugzilla) → review+
Updated•10 years ago
|
Attachment #8365705 -
Flags: review?(nical.bugzilla) → review+
Updated•10 years ago
|
Attachment #8365729 -
Flags: review?(nical.bugzilla) → review+
Updated•10 years ago
|
Attachment #8365730 -
Flags: review?(nical.bugzilla) → review+
Updated•10 years ago
|
Attachment #8365731 -
Flags: review?(nical.bugzilla) → review+
Updated•10 years ago
|
Attachment #8365732 -
Flags: review?(nical.bugzilla) → review+
Updated•10 years ago
|
Attachment #8365733 -
Flags: review?(nical.bugzilla) → review+
Updated•10 years ago
|
Attachment #8365734 -
Flags: review?(nical.bugzilla) → review+
Comment 65•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/7f4f11fa70cf https://hg.mozilla.org/mozilla-central/rev/17e04ba8fe30 https://hg.mozilla.org/mozilla-central/rev/558fb0c6a045 https://hg.mozilla.org/mozilla-central/rev/6d8a33dcab14 https://hg.mozilla.org/mozilla-central/rev/0ae9e982bf2f https://hg.mozilla.org/mozilla-central/rev/7776f7bdaa8d https://hg.mozilla.org/mozilla-central/rev/bafd28ce2b87
Assignee | ||
Comment 66•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/48317587ccef https://hg.mozilla.org/integration/mozilla-inbound/rev/70a77a2cb353 https://hg.mozilla.org/integration/mozilla-inbound/rev/cc6547917f0d https://hg.mozilla.org/integration/mozilla-inbound/rev/ec4df9a9a9c2 https://hg.mozilla.org/integration/mozilla-inbound/rev/9ffe3c056420 https://hg.mozilla.org/integration/mozilla-inbound/rev/b25ba289e7df https://hg.mozilla.org/integration/mozilla-inbound/rev/59320a8f2536
Comment 67•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/48317587ccef https://hg.mozilla.org/mozilla-central/rev/70a77a2cb353 https://hg.mozilla.org/mozilla-central/rev/cc6547917f0d https://hg.mozilla.org/mozilla-central/rev/ec4df9a9a9c2 https://hg.mozilla.org/mozilla-central/rev/9ffe3c056420 https://hg.mozilla.org/mozilla-central/rev/b25ba289e7df https://hg.mozilla.org/mozilla-central/rev/59320a8f2536
Assignee | ||
Comment 68•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/f17694ec185b https://hg.mozilla.org/integration/mozilla-inbound/rev/c2d4f16ed64a
Assignee | ||
Comment 69•10 years ago
|
||
Attachment #8351429 -
Attachment is obsolete: true
Comment 70•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/f17694ec185b https://hg.mozilla.org/mozilla-central/rev/c2d4f16ed64a https://hg.mozilla.org/mozilla-central/rev/27a2c7c78e8a
Assignee | ||
Comment 71•10 years ago
|
||
Attachment #8463029 -
Flags: review?(nical.bugzilla)
Assignee | ||
Comment 72•10 years ago
|
||
Attachment #8463030 -
Flags: review?(nical.bugzilla)
Assignee | ||
Comment 73•10 years ago
|
||
Attachment #8463031 -
Flags: review?(nical.bugzilla)
Assignee | ||
Comment 74•10 years ago
|
||
Attachment #8463032 -
Flags: review?(nical.bugzilla)
Assignee | ||
Comment 75•10 years ago
|
||
Attachment #8463033 -
Flags: review?(nical.bugzilla)
Assignee | ||
Comment 76•10 years ago
|
||
Attachment #8463034 -
Flags: review?(nical.bugzilla)
Assignee | ||
Comment 77•10 years ago
|
||
Attachment #8463035 -
Flags: review?(nical.bugzilla)
Assignee | ||
Comment 78•10 years ago
|
||
Attachment #8463078 -
Flags: review?(nical.bugzilla)
Assignee | ||
Comment 79•10 years ago
|
||
Attachment #8463079 -
Flags: review?(nical.bugzilla)
Assignee | ||
Comment 80•10 years ago
|
||
Attachment #8463151 -
Flags: review?(nical.bugzilla)
Assignee | ||
Comment 81•10 years ago
|
||
Attachment #8463173 -
Flags: review?(nical.bugzilla)
Assignee | ||
Comment 82•10 years ago
|
||
This adds the operator[] API to Matrix4x4. Not sure if we want to do that, but it does make certain operations simpler and matches gfx3DMatrix.
Attachment #8463174 -
Flags: review?(nical.bugzilla)
Updated•10 years ago
|
Attachment #8463029 -
Flags: review?(nical.bugzilla) → review+
Updated•10 years ago
|
Attachment #8463030 -
Flags: review?(nical.bugzilla) → review+
Updated•10 years ago
|
Attachment #8463031 -
Flags: review?(nical.bugzilla) → review+
Updated•10 years ago
|
Attachment #8463032 -
Flags: review?(nical.bugzilla) → review+
Updated•10 years ago
|
Attachment #8463033 -
Flags: review?(nical.bugzilla) → review+
Updated•10 years ago
|
Attachment #8463034 -
Flags: review?(nical.bugzilla) → review+
Updated•10 years ago
|
Attachment #8463035 -
Flags: review?(nical.bugzilla) → review+
Updated•10 years ago
|
Attachment #8463078 -
Flags: review?(nical.bugzilla) → review+
Updated•10 years ago
|
Attachment #8463079 -
Flags: review?(nical.bugzilla) → review+
Updated•10 years ago
|
Attachment #8463151 -
Flags: review?(nical.bugzilla) → review+
Updated•10 years ago
|
Attachment #8463173 -
Flags: review?(nical.bugzilla) → review+
Comment 83•10 years ago
|
||
Comment on attachment 8463174 [details] [diff] [review] Remove gfxPointH3D Review of attachment 8463174 [details] [diff] [review]: ----------------------------------------------------------------- ::: gfx/thebes/gfx3DMatrix.cpp @@ +493,5 @@ > > gfx3DMatrix > gfx3DMatrix::Inverse() const > { > + if (_11 == 0 && _21 == 0 && _31 == 0 && _41 == 1) { TransposedVector(aIndex) goes (&_11)+aIndex, etc. Looks like you forgot to offset by 3 here.
Attachment #8463174 -
Flags: review?(nical.bugzilla) → review-
All backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/05eb059f70bf for this reftest-no-accel failure: https://tbpl.mozilla.org/php/getParsedLog.php?id=44848645&tree=Mozilla-Inbound
Flags: needinfo?(dzbarsky)
Comment 85•10 years ago
|
||
Is it possible to add a Inverse(Matrix4x4 m) function somewhere? It seems rather cumbersome to always have to create a local temp variable to invert a matrix.
Comment 86•10 years ago
|
||
(Specifically for code like http://hg.mozilla.org/integration/mozilla-inbound/rev/765b7f67163e#l1.353)
Assignee | ||
Comment 87•10 years ago
|
||
Kats, that's a good idea. We can just put it on Matrix4x4 to match the gfx3DMatrix API. I'll do it next time I get a chance to work on this stuff. Relanded without the offending commit: remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/849e11005fc9 remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/941a77086c1a remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/9cd72d8361cb remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/1df59831403a remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/5e7fdb35499e remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/8924abe4f277 remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/7fbae4092ca9 remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/6643bed21a3e remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/d764f90842f3 Try run: https://tbpl.mozilla.org/?tree=Try&rev=2c67fa3069e6
Flags: needinfo?(dzbarsky)
Comment 88•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/849e11005fc9 https://hg.mozilla.org/mozilla-central/rev/941a77086c1a https://hg.mozilla.org/mozilla-central/rev/9cd72d8361cb https://hg.mozilla.org/mozilla-central/rev/1df59831403a https://hg.mozilla.org/mozilla-central/rev/5e7fdb35499e https://hg.mozilla.org/mozilla-central/rev/8924abe4f277 https://hg.mozilla.org/mozilla-central/rev/7fbae4092ca9 https://hg.mozilla.org/mozilla-central/rev/6643bed21a3e https://hg.mozilla.org/mozilla-central/rev/d764f90842f3
Assignee | ||
Comment 89•10 years ago
|
||
Good catch on the Inverse bug. That's the only thing I've changed here
Attachment #8463174 -
Attachment is obsolete: true
Attachment #8470019 -
Flags: review?(nical.bugzilla)
Updated•10 years ago
|
Attachment #8470019 -
Flags: review?(nical.bugzilla) → review+
Assignee | ||
Comment 90•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/3325dc888b50
Assignee | ||
Comment 91•10 years ago
|
||
Attachment #8476729 -
Flags: review?(nical.bugzilla)
Comment 92•10 years ago
|
||
(In reply to David Zbarsky (:dzbarsky) from comment #90) > https://hg.mozilla.org/integration/mozilla-inbound/rev/3325dc888b50 Reverted for build failures: https://tbpl.mozilla.org/php/getParsedLog.php?id=46475233&tree=Mozilla-Inbound https://tbpl.mozilla.org/php/getParsedLog.php?id=46477375&tree=Mozilla-Inbound https://tbpl.mozilla.org/php/getParsedLog.php?id=46475271&tree=Mozilla-Inbound remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/36ffb9b24c56
Assignee | ||
Updated•10 years ago
|
Summary: Switch gfxMatrix to gfx::Matrix → Switch gfx3DMatrix to gfx::Matrix4x4
Assignee | ||
Comment 93•10 years ago
|
||
Attachment #8477200 -
Flags: review?(nical.bugzilla)
Assignee | ||
Comment 94•10 years ago
|
||
Attachment #8477203 -
Flags: review?(nical.bugzilla)
Assignee | ||
Comment 95•10 years ago
|
||
Looks good on try: https://tbpl.mozilla.org/?tree=Try&rev=5215e602b598 remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/76987e4e811c remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/d02d8790e5c5
https://hg.mozilla.org/mozilla-central/rev/76987e4e811c https://hg.mozilla.org/mozilla-central/rev/d02d8790e5c5
Comment 97•10 years ago
|
||
Comment on attachment 8476729 [details] [diff] [review] nsLayoutUtils Review of attachment 8476729 [details] [diff] [review]: ----------------------------------------------------------------- Looks good. The parts of this patch in FrameLayerBuilder already made it to central (maybe some other parts too but not all of the patch). Looks like your patch queue is getting a bit messed up?
Attachment #8476729 -
Flags: review?(nical.bugzilla) → review+
Updated•10 years ago
|
Attachment #8477200 -
Flags: review?(nical.bugzilla) → review+
Updated•10 years ago
|
Attachment #8477203 -
Flags: review?(nical.bugzilla) → review+
Assignee | ||
Comment 98•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/8430feba6148
Comment 100•10 years ago
|
||
David, what's the status here? It would be good to have this finished off so that we can get rid of the overhead of the ToMatrix4x4 and To3DMatrix calls.
Flags: needinfo?(dzbarsky)
Assignee | ||
Comment 101•10 years ago
|
||
I ran into reftest failures on linux, presumably due to rounding error. I haven't had time to investigate and I'm not actively working on this bug.
Flags: needinfo?(dzbarsky)
Assignee | ||
Comment 102•10 years ago
|
||
This bug already has a ton of patches; we can do more in a followup.
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Summary: Switch gfx3DMatrix to gfx::Matrix4x4 → Switch some uses of gfx3DMatrix to gfx::Matrix4x4
Whiteboard: [leave open]
You need to log in
before you can comment on or make changes to this bug.
Description
•