Masatoshi Kimura [:emk] Assignee
	Description • 11 years ago

This is a non-standard extension derived from Navigator. It is not spec'ed and no other browsers support this. A standard alternative, width attribute, is available.

	Daniel Holbert [:dholbert]
	Comment 1 • 11 years ago

From a quick glance, I'd expect this would basically just require removing both usages of nsGkAtoms::cols from http://mxr.mozilla.org/mozilla-central/source/content/html/content/src/HTMLPreElement.cpp , right?

	Masatoshi Kimura [:emk] Assignee
	Comment 2 • 11 years ago

(In reply to Daniel Holbert [:dholbert] from comment #1)
> From a quick glance, I'd expect this would basically just require removing
> both usages of nsGkAtoms::cols from
> http://mxr.mozilla.org/mozilla-central/source/content/html/content/src/
> HTMLPreElement.cpp , right?

Basically, yes. We can remove a bit more (usages in ParseAttribute and IsAttributeMapped).

	Masatoshi Kimura [:emk] Assignee
	Comment 4 • 11 years ago

Try run: https://tbpl.mozilla.org/?tree=Try&rev=9b60d22aa226

	David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)
	Comment 5 • 11 years ago

Comment on attachment 8347216 [details] [diff] [review]
Drop support for "cols" attribute of <pre> elements

r=dbaron

But what other browsers support the width attribute?  It doesn't seem to be spec'd in HTML5 either, though it was in HTML4.  (Unless I'm looking in the wrong places, which I certainly could be.)

	Masatoshi Kimura [:emk] Assignee
	Comment 6 • 11 years ago

(In reply to David Baron [:dbaron] (needinfo? me) (UTC-5) from comment #5)
> But what other browsers support the width attribute?

Other browsers have HTMLPreElement.width property which will reflect the content attribute.

> It doesn't seem to be
> spec'd in HTML5 either, though it was in HTML4.  (Unless I'm looking in the
> wrong places, which I certainly could be.)

It is defined in the HTML5 spec, but in the Obsolete features section.
http://www.whatwg.org/specs/web-apps/current-work/multipage/obsolete.html#HTMLPreElement-partial
Note that this is defined under "Requirements for implementations" subsection, so user agents must implement this as spec'ed despite that authors must not depend on this feature.

HTML5 spec says nothing about the layout effect of the attribute. Actually, it has no visual effect on other browsers. So I was planning to remove the visual effect of the width element, but in a follow-up bug.

	Masatoshi Kimura [:emk] Assignee
	Comment 7 • 11 years ago

> width element
width attribute, of course.

	Masatoshi Kimura [:emk] Assignee
	Comment 8 • 11 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/4b78a373acbd

	Masatoshi Kimura [:emk] Assignee
	Comment 9 • 11 years ago

(In reply to Masatoshi Kimura [:emk] from comment #6)
> I was planning to remove the
> visual effect of the width element, but in a follow-up bug.

Filed bug 950737.

	Ryan VanderMeulen [:RyanVM]
	Comment 10 • 11 years ago

https://hg.mozilla.org/mozilla-central/rev/4b78a373acbd

	Kohei Yoshino [:kohei]
	Comment 11 • 10 years ago

https://developer.mozilla.org/en-US/Firefox/Releases/29/Site_Compatibility

	j.j.
	Comment 13 • 10 years ago

https://developer.mozilla.org/en-US/docs/Web/HTML/Element/pre
needs an update then ("cols" and "width" attributes don't work since version 29)

	Jean-Yves Perrier [:teoli]
	Comment 14 • 10 years ago

Updated