Andreas Tolfsen ❲:ato❳ Assignee
	Description • 11 years ago

The WebDriver specification mandates that we use strings for status
codes instead of numbers, which I think we should consider deprecated
behaviour.

However since no client bindings support status codes as strings yet
we should preserve the backwards compatible behavour for some time.
Since the status codes in Marionette appear to be hard coded, an
abstraction on status code would let us switch behaviour as needed.

See the status code section in the spec for further details:

    https://dvcs.w3.org/hg/webdriver/raw-file/tip/webdriver-spec.html#status-codes

See also the spec bug on introducing a new “invalid argument” status
code:

    https://www.w3.org/Bugs/Public/show_bug.cgi?id=23950

	David Burns :automatedtester
	Comment 1 • 10 years ago

Since this is going to be such a breaking change I am going to create a few blocking bugs so we can do this bit by bit

	Andreas Tolfsen ❲:ato❳ Assignee
	Comment 2 • 10 years ago

Working on this as part of a bigger series of patches.  The client side and flipping the switch in the server will be done in this patch.

	Andreas Tolfsen ❲:ato❳ Assignee
	Comment 3 • 9 years ago

/r/6729 - Bug 945729: Replace error number codes with strings

Pull down this commit:

hg pull -r 4debe2f4e0bc34d4a81530eda273f75f86f5af8d https://reviewboard-hg.mozilla.org/gecko/

	Andreas Tolfsen ❲:ato❳ Assignee
	Comment 4 • 9 years ago

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=c60ec23f3bde

	Andreas Tolfsen ❲:ato❳ Assignee
	Comment 5 • 9 years ago

We will expect some failures in the try job I pushed because we're waiting for bug 1152425 to land.  Will do another try run after that's landed.

	David Burns :automatedtester
	Comment 6 • 9 years ago

Comment on attachment 8589786 [details]
MozReview Request: bz://945729/ato

https://reviewboard.mozilla.org/r/6727/#review5637

::: testing/marionette/error.js
(Diff revision 1)
> -error.byCode = n => lookup.get(n);
> +// TODO(ato): Bug 1152409

Add more context to what this TODO is, the bug has no details about this Todo

::: testing/marionette/error.js
(Diff revision 1)
> +// TODO(ato): Bug 1152409

Add more context to this Todo

::: testing/marionette/elements.js
(Diff revision 1)
> -        throw new ElementException("No such strategy", 500, null);
> +        throw new ElementException("No such strategy", "webdriver error", null);

This should probably be `invalid selector`

::: testing/marionette/elements.js
(Diff revision 1)
> -        throw new ElementException("No such strategy", 500, null);
> +        throw new ElementException("No such strategy", "webdriver error", null);

This should probably be `invalid selector`

::: testing/marionette/listener.js
(Diff revision 1)
> -  let command_id = msg.json.command_id;
> +  let cmdId = msg.json.command_id;

Change the variable name back as it is useful to have them the same as the JSON variable name

::: testing/marionette/listener.js
(Diff revision 1)
> -  let propertyName = msg.json.propertyName;
> +  let prop = msg.json.propertyName;

Change the variable name back as it is useful to have them the same as the JSON variable name

	Andreas Tolfsen ❲:ato❳ Assignee
	Comment 7 • 9 years ago

https://reviewboard.mozilla.org/r/6727/#review5651

> This should probably be `invalid selector`

Filed bug 1152682 to address this.

> This should probably be `invalid selector`

Filed bug 1152682 to address this.

	Andreas Tolfsen ❲:ato❳ Assignee
	Comment 8 • 9 years ago

Comment on attachment 8589786 [details]
MozReview Request: bz://945729/ato

/r/6729 - Bug 945729: Replace error number codes with strings

Pull down this commit:

hg pull -r f6cfc57056e59acd0b2be02fee85f7c7a62939f2 https://reviewboard-hg.mozilla.org/gecko/

	David Burns :automatedtester
	Comment 9 • 9 years ago

Comment on attachment 8589786 [details]
MozReview Request: bz://945729/ato

https://reviewboard.mozilla.org/r/6727/#review5783

Ship It!

	Andreas Tolfsen ❲:ato❳ Assignee
	Comment 10 • 9 years ago

new try after rebase: https://treeherder.mozilla.org/#/jobs?repo=try&revision=86ccb52a0bae

	Pulsebot
	Comment 11 • 9 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/9947bd361636

	Carsten Book [:Tomcat]
	Comment 12 • 9 years ago

sorry had to backout for test failures like https://treeherder.mozilla.org/logviewer.html#?job_id=9113427&repo=mozilla-inbound

	Pulsebot
	Comment 13 • 9 years ago

Backout:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b844e7d074e5

	Andreas Tolfsen ❲:ato❳ Assignee
	Comment 14 • 9 years ago

Full try run, unfortunately based on inbound because it depends on some patches that are there:  https://treeherder.mozilla.org/#/jobs?repo=try&revision=e5d7123f6236

The problem was introduced in the rebase.

	Andreas Tolfsen ❲:ato❳ Assignee
	Comment 15 • 9 years ago

Another try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=c162057bc80f

	Pulsebot
	Comment 16 • 9 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/fc0b81ccd5fd

	Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)
	Comment 17 • 9 years ago

https://hg.mozilla.org/mozilla-central/rev/fc0b81ccd5fd