Closed
Bug 943416
Opened 11 years ago
Closed 11 years ago
Add the generic 'crash' signatures shown for hangs to the search term blacklist
Categories
(Tree Management Graveyard :: TBPL, defect)
Tree Management Graveyard
TBPL
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: emorley, Assigned: emorley)
References
Details
Attachments
(1 file)
1.09 KB,
patch
|
philor
:
review+
|
Details | Diff | Splinter Review |
To quote an email from philor to sheriffs@ { When a test hangs, and "application timed out after 330 seconds with no output," we kill the process just in case something interesting was happening, and put a "crash" stack in the log. There's almost never anything significant at the top of the stack, even when we were actually up to something, the (rare) significance is more likely to be buried in some other thread. But most of the time, we're just sitting spinning the event loop, waiting for something to happen that isn't ever going to happen, and the "crash" signature is CrashingThread(void *), or libSystem.B.dylib + 0xd7a, or linux-gate.so + 0x424. Those signatures mean absolutely nothing beyond what you're already saying in the summary, application timed out after 330 seconds with no output, but thanks to the power of (tbpl's bug) suggestion, if you look at hang bugs, you'll see that when we get in a hurry, we happily star things like "test_HTMLElement58.html | application timed out after 330 seconds with no output" as "Windows mochitest-1,2,3 hangs on Shutdown | application timed out after 330 seconds with no output". Please don't put any of those three things in bug summaries, please remove them when you see them, and please don't star new unfiled hangs as something utterly different in a different test. The only time we need them in the summary is when we don't have a test name, which should only be the case for Shutdown, where we just need to gather up the strength to not to call an unfiled test timeout a shutdown timeout, even if tbpl suggests it. } TBPL now supports whole line matching, even for items on the blacklist (ie "Shutdown"), so strings like "TEST-UNEXPECTED-FAIL | Shutdown | application timed out after 330 seconds with no output" will match - so we no longer need the fake 'crash' signature from the hang to match them. Therefore to avoid false positives, we can just add search terms for the following top frames, to the blacklist: [@ CrashingThread(void *)] (Windows) [@ libSystem.B.dylib + 0xd7a] (OS X) [@ linux-gate.so + 0x424] (Linux)
Assignee | ||
Updated•11 years ago
|
Summary: Add the generic 'crash' signatures seen for hangs to the search term blacklist → Add the generic 'crash' signatures shown for hangs to the search term blacklist
Assignee | ||
Comment 1•11 years ago
|
||
Phil, this idea sound ok to you in principal? I imagine there might be the odd bug that is no longer suggested (eg bug 889869), but I think this will be outweighed by the reduction in false positives.
Attachment #8338553 -
Flags: review?(philringnalda)
Comment 2•11 years ago
|
||
Comment on attachment 8338553 [details] [diff] [review] Patch v1 Seems reasonable to me, thanks.
Attachment #8338553 -
Flags: review?(philringnalda) → review+
Assignee | ||
Comment 3•11 years ago
|
||
Ty :-) https://hg.mozilla.org/webtools/tbpl/rev/293f1c40cee3
Assignee | ||
Comment 4•11 years ago
|
||
In production
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Updated•10 years ago
|
Product: Webtools → Tree Management
Updated•9 years ago
|
Product: Tree Management → Tree Management Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•