James Teh [:Jamie] Reporter
	Description • 11 years ago

Str:
1. Locate the accessible for the Navigation Toolbar (the parent of the address bar).
2. Check its accessible role (e.g. IAccessible2::role).
Expected: Role is toolbar.
Actual: Role is unknown.
3. Locate the accessible for the Browser Tabs toolbar (the parent of the tab control).
4. Check its accessible role.
Expected: Role is toolbar.
Actual: Role is unknown.
These both have a tag of "toolbar".

This next one is different:
5. Enable View -> Toolbars -> Bookmarks Toolbar.
6. Locate the accessible for the Most Visited button. (I assume is part of the Bookmarks toolbar, since it disappears when I disable it.)
7. Check the parent of this accessible.
Expected: The parent should be a toolbar.
Actual: The parent is the top level frame. There's not even an accessible with role unknown. The Navigation Toolbar is a sibling.

I'm guessing this has something to do with Australis.

	alexander :surkov (:asurkov) Assignee
	Comment 1 • 11 years ago

Marco, maybe you could take a look since you know UI part?

	Marco Zehe (:MarcoZ)
	Comment 2 • 11 years ago

Yes, I can confirm exactly as Jamie describes. A total mess.

	alexander :surkov (:asurkov) Assignee
	Comment 3 • 11 years ago

(In reply to Marco Zehe (:MarcoZ) from comment #2)
> Yes, I can confirm exactly as Jamie describes. A total mess.

Do you know that part of code?

	Marco Zehe (:MarcoZ)
	Comment 4 • 11 years ago

And this was not the case when I first tested Australlis build of November 18. Do we have another caching problem here?

	Marco Zehe (:MarcoZ)
	Comment 5 • 11 years ago

(In reply to alexander :surkov from comment #3)
> Do you know that part of code?

No.

	alexander :surkov (:asurkov) Assignee
	Comment 6 • 11 years ago

(In reply to Marco Zehe (:MarcoZ) from comment #4)
> And this was not the case when I first tested Australlis build of November
> 18. Do we have another caching problem here?

ok, cc'ing Trev then

	Marco Zehe (:MarcoZ)
	Comment 7 • 11 years ago

Confirm that this is still a case in the newest nightly build, but looks significantly different from the previous caching bug we had. This looks like a broken hierarchy. For example: I am getting doorhanger alerts spoken, but can't find the latest one in the hierarchy anywhere using either NVDA's object navigation or AccExplorer.

	James Teh [:Jamie] Reporter
	Comment 8 • 11 years ago

I wonder whether this is related to bug 934875. They occurred at different times, but perhaps the same issue is being triggered somehow?

	alexander :surkov (:asurkov) Assignee
	Comment 10 • 11 years ago

Comment on attachment 8342459 [details] [diff] [review]
patch

>diff --git a/accessible/public/nsIAccessibleText.idl b/accessible/public/nsIAccessibleText.idl
>--- a/accessible/public/nsIAccessibleText.idl

> 
>-[scriptable, uuid(1e63dd8b-173d-4a68-8ade-fd671abbe1ee)]
>+[scriptable, uuid(88789f40-54c9-494a-846d-3acaaf4cf46a)]

this is part of another bug, ignore it, fixed locally

	Marco Zehe (:MarcoZ)
	Comment 11 • 11 years ago

Ugh, is this a new implementation, and fronted developers weren't aware that NSIAccessibleProvider had gone, or was this an oversight from refactoring this stuff? May there be other instances lurking somewhere?

	alexander :surkov (:asurkov) Assignee
	Comment 12 • 11 years ago

(In reply to Marco Zehe (:MarcoZ) from comment #11)
> Ugh, is this a new implementation, and fronted developers weren't aware that
> NSIAccessibleProvider had gone, or was this an oversight from refactoring
> this stuff?

more plausible that was collision, I bet they did a copy/paste and also I bet Trev knows how to use search, so I guess they copied/pasted before Trevor pushed the change and landed the patch right after that.

> May there be other instances lurking somewhere?

mozilla-central search doesn't reveal anything

	alexander :surkov (:asurkov) Assignee
	Comment 13 • 11 years ago

http://hg.mozilla.org/integration/mozilla-inbound/rev/5097130acf24

	alexander :surkov (:asurkov) Assignee
	Comment 14 • 11 years ago

should it be backported somewhere?

	Marco Zehe (:MarcoZ)
	Comment 15 • 11 years ago

(In reply to alexander :surkov from comment #14)
> should it be backported somewhere?

I think this is an Australlis specific fix, so does not need to be back-ported.

	:Gijs (he/him)
	Comment 16 • 11 years ago

Please reland this with 'Australis' in the commit message. You can do a backout and a re-push with the adjusted commit message and specify DONTBUILD so we don't waste build resources.

	:Gijs (he/him)
	Comment 17 • 11 years ago

CC'ing folks so they're aware when merging

	alexander :surkov (:asurkov) Assignee
	Comment 18 • 11 years ago

http://hg.mozilla.org/integration/mozilla-inbound/rev/9050b8a0ce6d
http://hg.mozilla.org/integration/mozilla-inbound/rev/328d23950f63

	Ryan VanderMeulen [:RyanVM]
	Comment 19 • 11 years ago

https://hg.mozilla.org/mozilla-central/rev/328d23950f63

	u279076
	Comment 20 • 10 years ago

James Teh, can you please confirm this is fixed for you now in the latest Beta?

	u279076
	Comment 21 • 9 years ago

(In reply to Anthony Hughes, QA Mentor (:ashughes) from comment #20)
> James Teh, can you please confirm this is fixed for you now in the latest
> Beta?

Clearing this long overdue request.