Andreas Tolfsen ❲:ato❳ Assignee
	Description • 11 years ago

Marionette uses "screenShot" (camel case) for taking a screenshot of
the current browser window while the expected webdriver command is
"screenshot" (lower case).

This incompatibility makes it harder to use Marionette directly
without maintaining a WebDriver-to-Marionette command conversion set.

	Andreas Tolfsen ❲:ato❳ Assignee
	Comment 1 • 10 years ago

The spec is saying the command end-point should be "DOMString
takeScreenshot(optional WebElement el)".  Updated title to reflect
that.

To preserve Selenium compatibility we will still need "screenshot",
however.  Filed tracking bug 962181 and bug 962182 specifically about
this command.

	Andreas Tolfsen ❲:ato❳ Assignee
	Comment 2 • 10 years ago

try: https://tbpl.mozilla.org/?tree=Try&rev=82fdc39165ba

	David Burns :automatedtester
	Comment 3 • 10 years ago

Comment on attachment 8364342 [details] [diff] [review]
0001-Bug-941148-Rename-screenShot-to-takeScreenshot-for-w.patch

Review of attachment 8364342 [details] [diff] [review]:
-----------------------------------------------------------------

r+ can be carried through after nit corrected

::: testing/marionette/marionette-listener.js
@@ +2133,5 @@
>  
> +  // Return the Base64 String back to the client bindings and they can
> +  // manage saving the file to disk if it is required
> +  var dataUrl = canvas.toDataURL("image/png","");
> +    var data = dataUrl.substring(dataUrl.indexOf(",") + 1);

line up with rest of the code

	Andreas Tolfsen ❲:ato❳ Assignee
	Comment 4 • 10 years ago

Fixed issues, carrying on r+ from dburns.

	Ryan VanderMeulen [:RyanVM]
	Comment 5 • 10 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/95016fa7e7a0

	Ryan VanderMeulen [:RyanVM]
	Comment 6 • 10 years ago

https://hg.mozilla.org/mozilla-central/rev/95016fa7e7a0

	Ryan VanderMeulen [:RyanVM]
	Comment 7 • 10 years ago

https://hg.mozilla.org/releases/mozilla-aurora/rev/3ee86043f87f