Closed
Bug 941144
Opened 11 years ago
Closed 10 years ago
getWindows not matching Selenium command getCurrentWindowHandles
Categories
(Remote Protocol :: Marionette, defect)
Tracking
(firefox28 fixed, firefox29 fixed)
RESOLVED
FIXED
mozilla29
People
(Reporter: ato, Assigned: ato)
References
()
Details
Attachments
(1 file, 1 obsolete file)
4.12 KB,
patch
|
ato
:
review+
|
Details | Diff | Splinter Review |
Marionette uses "getWindows" getting a list of the open windows' handles while the expected webdriver command is "getCurrentWindowHandles". This incompatibility makes it harder to use Marionette directly without maintaining a WebDriver-to-Marionette command conversion set.
Updated•11 years ago
|
Assignee | ||
Updated•10 years ago
|
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → ato
Status: NEW → ASSIGNED
Assignee | ||
Comment 1•10 years ago
|
||
try: https://tbpl.mozilla.org/?tree=Try&rev=8f78315a4d84
Attachment #8364493 -
Flags: review?(dburns)
Comment 2•10 years ago
|
||
Comment on attachment 8364493 [details] [diff] [review] 0001-Bug-941144-getWindows-not-matching-Selenium-command.patch Review of attachment 8364493 [details] [diff] [review]: ----------------------------------------------------------------- ::: testing/marionette/marionette-server.js @@ +1199,2 @@ > this.command_id = this.getCommandId(); > + let rv = []; Why the change in variable name?
Attachment #8364493 -
Flags: review?(dburns) → review+
Assignee | ||
Comment 3•10 years ago
|
||
Oops, corrected. Attached updated patch for which I've carried on the r+.
Attachment #8364493 -
Attachment is obsolete: true
Attachment #8365026 -
Flags: review+
Assignee | ||
Updated•10 years ago
|
Keywords: checkin-needed
Comment 4•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/a53cbf955a90
Keywords: checkin-needed
Comment 5•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/a53cbf955a90
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
Comment 6•10 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/286d29768633
status-firefox28:
--- → fixed
status-firefox29:
--- → fixed
Updated•1 year ago
|
Product: Testing → Remote Protocol
You need to log in
before you can comment on or make changes to this bug.
Description
•