:glob ✱ Reporter
	Description • 11 years ago

see attached screenshot, where bug 927285's summary is forcing the bugs table under the flags tables.

	Dylan Hardison [:dylan] (he/him)
	Comment 1 • 10 years ago

I wonder which approach is best -- truncation or make the text scrollable?

	Dylan Hardison [:dylan] (he/him)
	Comment 2 • 10 years ago

Truncating this has proved to be more involved than I would have imagined, but I think a solution exists somewhere in the YUI data table configuration:

http://yuilibrary.com/yui/docs/datatable/

    CAVEAT: Column widths will expand beyond the configured value if column
    cells contain data that is long and can't line-wrap. Also, column widths
    may be reduced below the configured value if the table width (by
    configuring the DataTable's width attribute, or constrained by a narrow
    containing element) is too narrow to fit all data at the configured widths.

    To force column widths, including cell data truncation and allowing the
    table to spill beyond its configured or inherited width, wrap the cell
    content in a <div> either by configuring the column's formatter or
    cellTemplate, then assign the <div>'s CSS style with the desired width (or
    "inherit"), plus overflow: hidden;. Then set the DataTable column's width
    configuration accordingly.

	:glob ✱ Reporter
	Comment 4 • 10 years ago

Comment on attachment 8380622 [details] [diff] [review]
bug-929502-v1.patch

breaking on any character causes unreadable summaries, even in cases where the table isn't overlapping.

	Dylan Hardison [:dylan] (he/him)
	Comment 5 • 10 years ago

With a new test case that contains more than two words (*grin*) I have made some progress. Finding the right widths for each of the columns is proving a bit difficult -- and there is still a wrapping issue when you click the row expansion link.

	Dylan Hardison [:dylan] (he/him)
	Comment 6 • 10 years ago

I've not made much headway with making this look decent on both normal-sized and large-sized displays.

	Tomislav Jovanovic :zombie
	Comment 7 • 10 years ago

you can use regex to insert a "zero width space" unicode character on each word boundary, which would allow for line breaks on punctuation and other stuff.

if that is not enough, AND_LONG_TEXT_RUNS_LIKE_THIS_STILL_CAUSE_PROBLEMS, you can also break long (20+ char) words with the same technique.

	Dylan Hardison [:dylan] (he/him)
	Comment 9 • 10 years ago

Perhaps this will be fixed by porting to the jquery-based data table.

	Andreas Tolfsen ❲:ato❳
	Comment 12 • 10 years ago

It seems to me this should be solved using flexbox.

	gideon425xx
	Comment 17 • 9 years ago

I now have a fix for this.

I want to create a patch for review. However, I assume that I need to clone git.mozilla.org as part of this and I cannot see how to do this.

	gideon425xx
	Comment 18 • 9 years ago

okay, I think I have figured it out

	Dylan Hardison [:dylan] (he/him)
	Comment 20 • 9 years ago

Comment on attachment 8613297 [details] [diff] [review]
p1.txt

Review of attachment 8613297 [details] [diff] [review]:
-----------------------------------------------------------------

Aside from the issues regarding style, I don't see anything wrong with this approach. Fix the style and ask for review?

::: extensions/MyDashboard/web/js/query.js
@@ +87,5 @@
> +                var str;
> +                var str2;
> +                var count;
> +                var c2;
> +                for (c in e.response.results)

put the curly braces on the same line as their statement to match the existing code

	gideon425xx
	Comment 21 • 9 years ago

At the moment, the number of characters in each chunk is fixed. Perhaps I should make it configurable with a field in User Preferences

	:glob ✱ Reporter
	Comment 22 • 9 years ago

(In reply to gideon425xx from comment #21)
> At the moment, the number of characters in each chunk is fixed. Perhaps I
> should make it configurable with a field in User Preferences

there's no reason for that to be user or admin configurable.

ps. instead of appending a normal space it would probably be better to use a zero-width space - http://www.fileformat.info/info/unicode/char/200b/index.htm

	:glob ✱ Reporter
	Comment 23 • 9 years ago

(In reply to Byron Jones ‹:glob› from comment #22)
> ps. instead of appending a normal space it would probably be better to use a
> zero-width space -
> http://www.fileformat.info/info/unicode/char/200b/index.htm

.. or <wbr> - https://developer.mozilla.org/en-US/docs/Web/HTML/Element/wbr

	gideon425xx
	Comment 26 • 9 years ago

The two attachments (before is 8616026 and after is 8616027) show another issue with the dashboard, namely that when additional details for a bug are displayed, the box can widen to overlap one on the right.

I think it would be a good idea to fix this as part of this bug.

My idea now is to implement the fix using javascript and perl, but with less reliance on YUI. Also I would be using flexbox and style "white-space:pre-wrap; word-wrap:break-word" lines. I have tested this and it works with firefox, breaking at words where possible but splitting up words when they are longer than the available space. It also does not involve any hard-coding of numbers of characters.

Before I go ahead with this, I wanted to get a feeling that such a patch would be approved for integration. Do you see any problems with my proposal?

	:glob ✱ Reporter
	Comment 27 • 9 years ago

(In reply to gideon425xx from comment #26)

> Before I go ahead with this, I wanted to get a feeling that such a patch
> would be approved for integration. Do you see any problems with my proposal?

i can't think of any issues with that proposal.

	gideon425xx
	Comment 28 • 9 years ago

Just a quick note to say that work is continuing on this

	gideon425xx
	Comment 29 • 9 years ago

I am stopping work on this. To fix this in the way I had intended seems like a lot of changes for my first contribution to bmo, risking breaking a lot of things.