Closed Bug 922214 Opened 11 years ago Closed 11 years ago

Add console.exception

Categories

(DevTools :: Console, defect, P3)

defect

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 28

People

(Reporter: fitzgen, Assigned: denschub)

References

Details

(Keywords: dev-doc-complete)

Attachments

(1 file, 1 obsolete file)

Possibly a good-first-bug, but I wouldn't know how to mentor it.
not a good first bug. :)
Assignee: nobody → mozilla
Status: NEW → ASSIGNED
OS: Mac OS X → All
Priority: -- → P3
Hardware: x86 → All
Attachment #8340676 - Flags: review?(mihai.sucan)
Comment on attachment 8340676 [details] [diff] [review]
Proposed implementation of console.exception()

Review of attachment 8340676 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you Dennis for the patch! This is looking good, but one of the webconsole tests fails:

TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/webconsole/test/browser_webconsole_console_extras.js | only two messages are displayed - Got 3, expected 2

Please make sure you always run all of the tests.
Attachment #8340676 - Flags: review?(mihai.sucan)
Uh, I'm sorry. Here we are, with passing tests. :)
Attachment #8340676 - Attachment is obsolete: true
Attachment #8341201 - Flags: review?(mihai.sucan)
Comment on attachment 8341201 [details] [diff] [review]
Proposed implementation of console.exception()

Thank you for the updated patch! This looks good. r+

Try push https://tbpl.mozilla.org/?tree=Try&rev=7b7c7340f503

Once it's all green, I will land the patch.
Attachment #8341201 - Flags: review?(mihai.sucan) → review+
Keywords: dev-doc-needed
https://hg.mozilla.org/mozilla-central/rev/0dfe710c2d64
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 28
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: