Ben Turner (not reading bugmail, use the needinfo flag!) Assignee
	Description • 11 years ago

At the Google meetup a while back we all agreed that openKeyCursor should exist on IDBObjectStore as well as IDBIndex.

Requires bug 920179 in order for the tests to work.

	Ben Turner (not reading bugmail, use the needinfo flag!) Assignee
	Comment 1 • 11 years ago

There are a bunch of s/NS_ASSERTION/MOZ_ASSERT/ changes in here but I tried to only touch the ones where I actually needed to change the method. Hopefully it's not too noisy.

	Jan Varga [:janv]
	Comment 2 • 11 years ago

Comment on attachment 810192 [details] [diff] [review]
Patch, v1

Review of attachment 810192 [details] [diff] [review]:
-----------------------------------------------------------------

looks good

::: dom/indexedDB/test/unit/test_objectStore_openKeyCursor.js
@@ +264,5 @@
> +    }
> +  }
> +  ok(match, "All keys matched");
> +
> +

Nit: extra empty line ?

	Ben Turner (not reading bugmail, use the needinfo flag!) Assignee
	Comment 3 • 11 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/bb0041643a0f

	Ryan VanderMeulen [:RyanVM]
	Comment 4 • 11 years ago

Backed out because this depends on bug 920179 which had to be backed out.
https://hg.mozilla.org/integration/mozilla-inbound/rev/19b202186812

	Ben Turner (not reading bugmail, use the needinfo flag!) Assignee
	Comment 5 • 11 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/87a72129c007

	Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)
	Comment 6 • 11 years ago

And out again: http://hg.mozilla.org/integration/mozilla-inbound/rev/a11f8859f7d8

	Ben Turner (not reading bugmail, use the needinfo flag!) Assignee
	Comment 7 • 11 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/a8aca6978ed9 should work.

	Carsten Book [:Tomcat]
	Comment 8 • 11 years ago

https://hg.mozilla.org/mozilla-central/rev/a8aca6978ed9

	Jean-Yves Perrier [:teoli]
	Comment 9 • 10 years ago

Doc up-to-date:
https://developer.mozilla.org/en-US/Firefox/Releases/27#Interfaces.2FAPIs.2FDOM
and
https://developer.mozilla.org/en-US/docs/Web/API/IDBObjectStore.openKeyCursor