Boris Zbarsky [:bzbarsky] Reporter
	Description • 11 years ago

See https://www.w3.org/Bugs/Public/show_bug.cgi?id=22808

We can't just do this: our chrome uses this all over.  Including the addon SDK.  A try push with this change is beautifully orange.

So I'm going to see if we can disable this for non-chrome callers only, for now and then get our tests passing.  And if we can, I will then reenable it for non-chrome code, add telemetry, and see what we see in the wild.

	Boris Zbarsky [:bzbarsky] Reporter
	Comment 1 • 11 years ago

https://tbpl.mozilla.org/?tree=Try&rev=f2d188af713c says failures in M1, M2, M3, M5, mochitest-browser-chrome, mochitest-chrome, crashtest, crashtest-ipc, jetpack tests.  And probably the robocop tests (rc2) on Android 2.2.

	Bobby Holley (:bholley) Assignee
	Comment 4 • 10 years ago

https://tbpl.mozilla.org/?tree=Try&rev=ebdbc851ae3d

	Bobby Holley (:bholley) Assignee
	Comment 5 • 10 years ago

https://tbpl.mozilla.org/?tree=Try&rev=14e707d8688c

	Bobby Holley (:bholley) Assignee
	Comment 6 • 10 years ago

I DeMorgan-ified the previous patch because I was finding it very difficult to
grok, even though I understood the change it was making.

	Bobby Holley (:bholley) Assignee
	Comment 7 • 10 years ago

https://tbpl.mozilla.org/?tree=Try&rev=27919b9e2a5d

	Boris Zbarsky [:bzbarsky] Reporter
	Comment 8 • 10 years ago

Comment on attachment 8381519 [details] [diff] [review]
Disable invoking WebIDL constructors without |new| unless you have the system principal. v2

r=me, but before you can land this you need to fix the gaia code that depends on the current behavior, no?

At the very least, http://mxr.mozilla.org/gaia/search?string=TextEncoder%28&find=&findi=&filter=^[^\0]*%24&hitlimit=&tree=gaia shows hits in the mail app, and similar for TextDecoder.  Not sure about other constructors that are worth checking for (e.g. Event() is really hard to search for).

If this passed tests, that mostly tells us that b2g test coverage is terrible, which is not a surprise.  :(

	Bobby Holley (:bholley) Assignee
	Comment 9 • 10 years ago

(In reply to Boris Zbarsky [:bz] (reviews will be slow; ask someone else) from comment #8)
> Comment on attachment 8381519 [details] [diff] [review]
> Disable invoking WebIDL constructors without |new| unless you have the
> system principal. v2
> 
> r=me, but before you can land this you need to fix the gaia code that
> depends on the current behavior, no?

Yeah. The try push in comment 7 is orange on Gaia, though probably not as orange as it should be. I'm looking into it, but it's all bundled up in sinon.js stuff.

	Bobby Holley (:bholley) Assignee
	Comment 10 • 10 years ago

Try push with a custom gaia including my changes from the dependent bugs:

https://tbpl.mozilla.org/?tree=Try&rev=0bf700091431

	Bobby Holley (:bholley) Assignee
	Comment 11 • 10 years ago

https://tbpl.mozilla.org/?tree=Try&rev=728bf49ceb83

	Bobby Holley (:bholley) Assignee
	Comment 12 • 10 years ago

https://tbpl.mozilla.org/?tree=Try&rev=05180848d19c

	Bobby Holley (:bholley) Assignee
	Comment 13 • 10 years ago

(In reply to Bobby Holley (:bholley) from comment #12)
> https://tbpl.mozilla.org/?tree=Try&rev=05180848d19c

The gaia stuff here is green with my patches.

	Bobby Holley (:bholley) Assignee
	Comment 14 • 10 years ago

Gaia changes should be merged in now. Try push without custom gaia:

https://tbpl.mozilla.org/?tree=Try&rev=6831a6cfbebc

	Bobby Holley (:bholley) Assignee
	Comment 15 • 10 years ago

Looks like Gaia bumps don't git m-c as frequently as I'd thought. Should be there by now:

https://tbpl.mozilla.org/?tree=Try&rev=33eb326fcc42

	Bobby Holley (:bholley) Assignee
	Comment 16 • 10 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/de377011ed9d

	Ryan VanderMeulen [:RyanVM]
	Comment 17 • 10 years ago

https://hg.mozilla.org/mozilla-central/rev/de377011ed9d

	Boris Zbarsky [:bzbarsky] Reporter
	Comment 18 • 10 years ago

We probably want a followup for fixing the system-caller behavior too...

	Kohei Yoshino [:kohei]
	Comment 19 • 10 years ago

https://developer.mozilla.org/en-US/Firefox/Releases/30/Site_Compatibility