David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla) Assignee
	Description • 11 years ago

http://software.hixie.ch/utilities/js/live-dom-viewer/?saved=2517 shows that other browsers (IE, blink, WebKit) no longer implement the quirk added in bug 99554 to allow {} around the style attribute.  We should remove this.

(Discussed in CSS meeting today, briefly.)

	David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla) Assignee
	Comment 1 • 11 years ago

The tests pass with the patch; without the patch
test_style_attribute_quirks.html fails 2 tests.

	Cameron McCormack (:heycam)
	Comment 2 • 11 years ago

Comment on attachment 802989 [details] [diff] [review]
Remove quirk allowing {} around style attribute.

Review of attachment 802989 [details] [diff] [review]:
-----------------------------------------------------------------

(I guess it would have been simpler to write the test as a reftest, but either way.)

	David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla) Assignee
	Comment 3 • 11 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/a2a946c673af

	David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla) Assignee
	Comment 4 • 11 years ago

(In reply to Cameron McCormack (:heycam) from comment #2)
> (I guess it would have been simpler to write the test as a reftest, but
> either way.)

Script tests should be lower-overhead to run, though.

	Ryan VanderMeulen [:RyanVM]
	Comment 5 • 11 years ago

https://hg.mozilla.org/mozilla-central/rev/a2a946c673af

	Jean-Yves Perrier [:teoli]
	Comment 6 • 11 years ago

Adding dev-doc-needed, I'm not sure this was previously documented, but if so we have to fix the documentation.

	Simon Pieters [:zcorpan]
	Comment 7 • 11 years ago

"In quirks mode, the CSS parser allows {} around the contents of style attributes (bug 99554)."
https://developer.mozilla.org/en-US/docs/Mozilla_Quirks_Mode_Behavior

	Daniel Holbert [:dholbert]
	Comment 8 • 11 years ago

I added a sentence "This behavior is being removed in Firefox 27, for interoperability.", plus a link to this bug, after the quote in Comment 7.  Feel free to edit/extend as appropriate.

Leaving dev-doc-needed in case there's anything else that needs updating.

	:Ms2ger (he/him; ⌚ UTC+1/+2)
	Comment 9 • 11 years ago

Simon, what's the testing situation here?

	Simon Pieters [:zcorpan]
	Comment 10 • 11 years ago

I've submitted http://hg.csswg.org/test/rev/0274e82f1553 (feel free to review so it can be moved to approved)

	Kohei Yoshino [:kohei]
	Comment 11 • 11 years ago

https://developer.mozilla.org/en-US/Firefox/Releases/27/Site_Compatibility