Boris Zbarsky [:bzbarsky] Reporter
	Description • 11 years ago

Per spec, we should return false when the list is too long or has too-large entries.  We're throwing instead.

	Mounir Lamouri (:mounir)
	Comment 1 • 11 years ago

I think returning false is better than throwing, we should fix our implementation.

Justin, do you have cycles to take this?

	Justin Lebar (not reading bugmail)
	Comment 2 • 11 years ago

I'd hate to deprive someone of a valuable learning experience; do we have anyone new to take this?  Otherwise sure, it's not a bug deal

	Boris Zbarsky [:bzbarsky] Reporter
	Comment 3 • 11 years ago

Either way, please don't touch this code until I land bug 838146!

	David Bruant
	Comment 4 • 11 years ago

(In reply to Justin Lebar [:jlebar] from comment #2)
> I'd hate to deprive someone of a valuable learning experience; do we have
> anyone new to take this?  Otherwise sure, it's not a bug deal
CC'ing jdm

	Josh Matthews [:jdm]
	Comment 5 • 11 years ago

Maria, this one is a simple change that could interest you.

	(no longer active)
	Comment 7 • 11 years ago

I'm not sure if Justin is still available for reviews...

	Olli Pettay [:smaug][bugs@pettay.fi]
	Comment 8 • 11 years ago

Comment on attachment 809531 [details] [diff] [review]
Impl

https://tbpl.mozilla.org/?tree=Try&rev=7b2ca3c3e626

	Andrew Quartey [:drexler] Assignee
	Comment 9 • 11 years ago

inbound: http://hg.mozilla.org/integration/mozilla-inbound/rev/bbf7f7deb76f

	Carsten Book [:Tomcat]
	Comment 10 • 11 years ago

https://hg.mozilla.org/mozilla-central/rev/bbf7f7deb76f

	bhavana bajaj [:bajaj]
	Comment 11 • 11 years ago

teoli, 

Seems to impact firefox OS only ? Unclear why would release note it on desktop/android .

	Jean-Yves Perrier [:teoli]
	Comment 12 • 11 years ago

:bajaj, it impacts Firefox for Android too (but not Desktop as it has no vibrating device). Can anyone else comfirm/infirm? Andrew?

	Andrew Quartey [:drexler] Assignee
	Comment 13 • 11 years ago

(In reply to Jean-Yves Perrier [:teoli] from comment #12)
> :bajaj, it impacts Firefox for Android too (but not Desktop as it has no
> vibrating device). Can anyone else comfirm/infirm? Andrew?

Unless, i'm mistaken this should be for firefox OS and Android only, right Boris?

	Andrew Quartey [:drexler] Assignee
	Comment 14 • 11 years ago

Do see comment 12.

	Olli Pettay [:smaug][bugs@pettay.fi]
	Comment 15 • 11 years ago

We do expose vibrate() on desktop too and this affects the behavior there.

	Boris Zbarsky [:bzbarsky] Reporter
	Comment 16 • 11 years ago

Indeed.  There is no vibration on desktop, but the API is present, and the behavior is detectable by the web page: it gets an exception from a call that should not, per spec, throw one.  Which is obviously less than ideal.

	Jean-Yves Perrier [:teoli]
	Comment 17 • 10 years ago

Doc updated: https://developer.mozilla.org/en-US/Firefox/Releases/27
and
https://developer.mozilla.org/en-US/docs/Web/API/Navigator.vibrate