Liz Henry (:lizzard) (relman/hg->git project) Reporter
	Description • 11 years ago

We could add links to the Socorro report/list pages for the signatures, e.g. https://crash-stats.mozilla.com/report/list?signature=ScanRope 

If there are crash signatures associated with a bug, each signature could have a link next to it that goes to crash-stats. As kairo pointed out in https://bugzilla.mozilla.org/show_bug.cgi?id=877895#c4 that crash-stats page will have a tab that links all bugs connected to that signature.

	:glob ✱ Assignee
	Comment 1 • 11 years ago

i think the use-case for this request isn't solid enough to expose it to all users.

it should happen in a firefox addon, or on an opt-in basis via some mechanism (group membership, preference, etc).

	:glob ✱ Assignee
	Comment 2 • 11 years ago

.. or wait for the role-specific pages and add it to the triage page.

	Robert Kaiser
	Comment 3 • 11 years ago

The main use case for this is what me and other stability investigators are doing almost every time we're asked about any details to a crash in a bug, and that's going to *exactly that* report/list page and getting info off the Signature Summary, Reports, Comments, or other tabs there. This page is where anyone can find all relevant data off reports for this crash signature - which versions it happens in, if it's mostly at startup or later in execution, which OSes, Flash versions, dates, etc. it's happening on - and what comments people leave us when encountering it, which often gives us clues as to how to reproduce. Not to mention correlations with loaded libraries or add-ons. All of that is on this report/list page.

	Robert Kaiser
	Comment 4 • 11 years ago

That said, right now we work around this mostly by having this link posted in a comment in almost every single crash bug out there. Just look at bugs with the crash keyword and find those links there, in most cases even in comment #0 as we consider this link part of the basic info you need about a crash.

	Mats Palmgren (inactive)
	Comment 5 • 9 years ago

FWIW, I would also find such links useful.  I don't see how the current textual data
is more useful to anyone.

	:glob ✱ Assignee
	Comment 6 • 9 years ago

how about we support socorro urls the see-also field?

> FWIW, I would also find such links useful.  I don't see how the current
> textual data is more useful to anyone.

searching by crash sig?

	Robert Kaiser
	Comment 7 • 9 years ago

Glob, not sure what you mean. Also, we already have the crash signature field, I don't want us to need adding info to any other field like See Also.

	Mats Palmgren (inactive)
	Comment 8 • 9 years ago

(In reply to Byron Jones ‹:glob› from comment #6)
> searching by crash sig?

Searching where exactly? Bugzilla? Google? Neither of those is particularly
useful.  The only useful signature search is in Socorro, which is what
the suggested links are for!

	:glob ✱ Assignee
	Comment 9 • 9 years ago

i spoke with kairo directly to clarify this request.

when viewing the crash-signature field (before you click edit) we need to linkify each signature to socorro.

the signatures are bounded by \[\@\s* and \s*\]
each signature should be linked to https://crash-stats.mozilla.com/report/list?signature=$signature

for example:

a crash signature field with
--
[@ js::gc::ScanRope ]
[@ ScanRope]
--

should render as
--
<a href="https://crash-stats.mozilla.com/report/list?signature=js%3A%3Agc%3A%3AScanRope">[@ js::gc::ScanRope ]</a><br>
<a href="https://crash-stats.mozilla.com/report/list?signature=ScanRope">[@ ScanRope ]</a><br>
--

note: it's valid for signature to contain brackets:
--
[@ -[ChildView keyDown:]]
[@ -[ChildView keyDown:] ]
--

	:glob ✱ Assignee
	Comment 10 • 9 years ago

perl's core Text::Balanced module makes parsing that field a breeze :)

	:glob ✱ Assignee
	Comment 11 • 9 years ago

what about signatures like: [@ xul.dll@0x1a42790 | SandboxCreateXMLHttpRequest]

with the current patch this will link to
https://crash-stats.mozilla.com/report/list?signature=xul.dll@0x1a42790%20|%20SandboxCreateXMLHttpRequest ?

i suspect we should be linking to
https://crash-stats.mozilla.com/report/list?signature=SandboxCreateXMLHttpRequest

is there a spec describing the signatures?

if not, what are the rules surrounding these sorts of signatures?

my guess is "if the sig contains a pipe, remove everything up to the pipe then trim whitespace from the remainder".

	Robert Kaiser
	Comment 12 • 9 years ago

(In reply to Byron Jones ‹:glob› from comment #11)
> what about signatures like: [@ xul.dll@0x1a42790 |
> SandboxCreateXMLHttpRequest]
> 
> with the current patch this will link to
> https://crash-stats.mozilla.com/report/list?signature=xul.
> dll@0x1a42790%20|%20SandboxCreateXMLHttpRequest ?

Yes, that's how it should be.

> i suspect we should be linking to
> https://crash-stats.mozilla.com/report/
> list?signature=SandboxCreateXMLHttpRequest

No, that's wrong. the pipes are part of the signature, it just marks that the signature is a compound of multiple stack frames.

> is there a spec describing the signatures?

No, and for those links, we need to link full signatures anyhow, not decomposing them at all.

	David Lawrence [:dkl]
	Comment 13 • 9 years ago

Comment on attachment 8569970 [details] [diff] [review]
880552_1.patch

Review of attachment 8569970 [details] [diff] [review]:
-----------------------------------------------------------------

Looks great. r=dkl

::: extensions/BMO/template/en/default/hook/bug/edit-custom_field.html.tmpl
@@ +20,5 @@
> +%]
> +  [%# lifted from bug/field.html.tmpl %]
> +  <tr>
> +    [% PROCESS "bug/field-label.html.tmpl" %]
> +    <td class="field_value [% ' bz_hidden_field' IF hidden %]"

IF hidden part is not needed here.

	:glob ✱ Assignee
	Comment 14 • 9 years ago

To ssh://gitolite3@git.mozilla.org/webtools/bmo/bugzilla.git
   a428a86..3208ebb  master -> master

	Liz Henry (:lizzard) (relman/hg->git project) Reporter
	Comment 15 • 9 years ago

This is going to be very useful! Thanks Byron and dkl!