Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(away 4/27 - 5/6) Assignee
	Description • 11 years ago

On Windows, some virtual keycode values for IME related keys are shared between Japanese keyboard layout and Korean keyboard layout. We should use different key values for them by checking the keyboard layout locale.

Additionally, some keys for IME cause OEM virtual keycodes. They should also be mapped with keyboard layout locale.

	Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(away 4/27 - 5/6) Assignee
	Comment 1 • 11 years ago

See comment 0 for the detail.

	Olli Pettay [:smaug][bugs@pettay.fi]
	Comment 2 • 11 years ago

Comment on attachment 768199 [details] [diff] [review]
Refer current keyboard layout locale at mapping from native keycode to D3E key name index on Windows

I assume this makes us behave like IE does.

	Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(away 4/27 - 5/6) Assignee
	Comment 3 • 11 years ago

> I assume this makes us behave like IE does.

IE 10 doesn't support the special keys of Korean keyboard. They are mapped to "Unindentified".

Additionally, "FullWidth", "HalfWidth", "Alphanumeric", "Hiragana" and "Katakana" of Japanese keyboard layout are mapped to "Unidentified".

Finally, IE 10 maps "KanaMode" to "Attn" because the virtual keycode VK_ATTN is used for the Kana Mode/Roman Character mode key. I believe that this is a bug of IE because the key isn't actual "attention" key.

So, our implementation will advance one more step than IE 10.

	Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(away 4/27 - 5/6) Assignee
	Comment 4 • 11 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/b5fddca814e0

	Ed Morley [:emorley]
	Comment 5 • 11 years ago

https://hg.mozilla.org/mozilla-central/rev/b5fddca814e0

	Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(away 4/27 - 5/6) Assignee
	Comment 6 • 11 years ago

https://developer.mozilla.org/en-US/docs/Web/API/KeyboardEvent#Key_names_and_Char_values