Olli Pettay [:smaug][bugs@pettay.fi] Assignee
	Description • 11 years ago

Better to do this after webidl-fication.

	Olli Pettay [:smaug][bugs@pettay.fi] Assignee
	Comment 1 • 11 years ago

https://tbpl.mozilla.org/?tree=Try&rev=3a808680861b

	David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)
	Comment 2 • 11 years ago

Comment on attachment 745567 [details] [diff] [review]
patch

Could you add an assertion at the start of 
ElementAnimations::GetPositionInIteration that
!aAnimation == !aEa && !aAnimation == !aEventsToDispatch.


>+is(e.elapsedTime, "0.5");

I'm surprised the 0.5 is in quotes.  Does that work?



And again, it would be good to remove initAnimationEvent in a followup patch.

r=dbaron

	Olli Pettay [:smaug][bugs@pettay.fi] Assignee
	Comment 4 • 11 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/cdc859533b8d

	Phil Ringnalda (:philor)
	Comment 5 • 11 years ago

https://hg.mozilla.org/mozilla-central/rev/cdc859533b8d

	Jean-Yves Perrier [:teoli]
	Comment 6 • 11 years ago

Doc updated/created:
https://developer.mozilla.org/en-US/docs/Web/API/AnimationEvent
https://developer.mozilla.org/en-US/docs/Web/API/AnimationEvent.AnimationEvent
https://developer.mozilla.org/en-US/docs/Web/API/AnimationEvent.pseudoElement
https://developer.mozilla.org/en-US/docs/Mozilla/Firefox/Releases/23

I didn't changed:
https://developer.mozilla.org/en-US/docs/Web/API/AnimationEvent.initAnimationEvent
because the new fourth optional arguments never went into a release as the method has been removed by bug 868751 (that is still in progress to be documented).