Simon Green Assignee
	Description • 11 years ago

With the changes in bug 752946 it is possible to create a new bug (either via RPC or URL hijacking) with a milestone that is inactive. This shouldn't be allowed.

	Simon Green Assignee
	Comment 1 • 11 years ago

I've request the blocking on this bug on the same basis as the bug that created the problem.

	Frédéric Buclin
	Comment 2 • 11 years ago

Comment on attachment 713221 [details] [diff] [review]
v1 patch

I think the problem you describe affects versions and components too. IMO, the right fix is to write:

my $old_foo = blessed($invocant) ? $invocant->foo : '';

This way, the first part of

  if ($object->name ne $old_foo && !$object->is_active)

will always be false for new bugs (a component, version or milestone cannot be '') and we will always call !$object->is_active.

So please fix this issue for versions and components too.

	Frédéric Buclin
	Comment 3 • 11 years ago

This is less problematic for new bugs, because the UI doesn't list inactive values. So unless you hack the URL directly, honest users are not affected by this issue. But I'm fine to take it for 4.2.5 anyway as the fix in bug 752946 is incomplete.

	Frédéric Buclin
	Comment 5 • 11 years ago

Comment on attachment 713735 [details] [diff] [review]
v2 patch

No need to write : '' on its own line. On checkin, it should be moved on the same line as foo ? bar. r=LpSolit

	Frédéric Buclin
	Comment 6 • 11 years ago

Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/trunk/
modified Bugzilla/Bug.pm
Committed revision 8577.

Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/4.4/
modified Bugzilla/Bug.pm
Committed revision 8518.

Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/4.2/
modified Bugzilla/Bug.pm
Committed revision 8187.