Closed Bug 839371 Opened 11 years ago Closed 11 years ago

Implement HTML5 <data> element

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set
normal

Tracking

()

VERIFIED FIXED
mozilla22
Tracking Status
relnote-firefox --- 22+

People

(Reporter: humph, Assigned: humph)

References

()

Details

(Keywords: dev-doc-complete)

Attachments

(1 file, 1 obsolete file)

Related to the <time> element from bug 629801, "The data element represents its contents, along with a machine-readable form of those contents in the value attribute."

interface HTMLDataElement : HTMLElement {
           attribute DOMString value;
};

Is it OK to do this one now too, or should we wait? (spec doc says, "Experimental draft").  If 'yes' I'll do it now as I finish up <time>.  I think both are going to be pretty useful.
Henri, you might know the answer. How stable is the spec?
I'm not aware of any relevant implementation-affecting outstanding feedback for <data>, for what it's worth.
Attached patch v1 (obsolete) — Splinter Review
Assignee: nobody → david.humphrey
Status: NEW → ASSIGNED
Attachment #718095 - Flags: review?(bugs)
Comment on attachment 718095 [details] [diff] [review]
v1


>+JSObject*
>+HTMLDataElement::WrapNode(JSContext* cx, JSObject* scope, bool* triedToWrap)
aCx, aScope, aTriedToWrap
Attachment #718095 - Flags: review?(bugs) → review+
Attached patch v2 (r=smaug)Splinter Review
I've fixed that nit, thanks for the quick review.

Do you want anyone else to look at this, or can it land?
Attachment #718095 - Attachment is obsolete: true
I think this should be fine.
Keywords: checkin-needed
Keywords: dev-doc-needed
https://hg.mozilla.org/mozilla-central/rev/4d3e8e7ee977
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla22
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:22.0) Gecko/20130403 Firefox/22.0
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:22.0) Gecko/20130403 Firefox/22.0
Mozilla/5.0 (X11; Linux i686; rv:22.0) Gecko/20130402 Firefox/22.0
BuildID: 20130402004013

I also performed some testing around this element on latest Firefox 22 Aurora builds across main platforms and there were no related visual issues or errors on pages using the <data> tag.
Based on this and the fact that there is a test page for this element, I'm marking the bug Verified.
Status: RESOLVED → VERIFIED
This bug has been listed as part of the Aurora 22 release notes in either [1], [2], or both. If you find any of the information or wording incorrect in the notes, please email release-mgmt@mozilla.com asap. Thanks!

[1] https://www.mozilla.org/en-US/firefox/22.0a2/auroranotes/
[2] https://www.mozilla.org/en-US/mobile/22.0a2/auroranotes/
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: