:Ms2ger (he/him; ⌚ UTC+1/+2) Reporter
	Description • 11 years ago

The spec (<https://svgwg.org/svg2-draft/types.html#__svg__SVGElement__ownerSVGElement>) says:

ownerSVGElement (readonly SVGSVGElement)
    The nearest ancestor ‘svg’ element. Null if the given element is the outermost svg element.

Our implementation has:

1138   // If we didn't find anything and we're not the outermost SVG element,
1139   // we've got an invalid structure
1140   if (!ownerSVGElement && Tag() != nsGkAtoms::svg) {
1141     rv.Throw(NS_ERROR_FAILURE);
1142   }

which doesn't seem to make sense to me.

	Robert Longson [:longsonr] Assignee
	Comment 1 • 11 years ago

It throws if you write <g xmlns="xmlns="http://www.w3.org/2000/svg"><rect id="r"></g> which is not a valid svg file as the root element is not <svg>.

Since the specification doesn't say to throw and returning null is reasonable I think we should do that.

	Jonathan Watt [:jwatt]
	Comment 3 • 11 years ago

What do Chrome and IE do?

	Robert Longson [:longsonr] Assignee
	Comment 4 • 11 years ago

Firefox throws and displays an error in the console
IE 9 prints null
Opera prints null

Dunno about Chrome.

	:Ms2ger (he/him; ⌚ UTC+1/+2) Reporter
	Comment 5 • 11 years ago

null in Chrome too.

	Jonathan Watt [:jwatt]
	Comment 6 • 11 years ago

Comment on attachment 785522 [details] [diff] [review]
patch

Okay, sounds like we should definitely do this then. Thanks!

	Jonathan Watt [:jwatt]
	Comment 7 • 11 years ago

Can you change:

  return GetCtx();

to:

  return GetCtx(); // this may return nullptr

	Robert Longson [:longsonr] Assignee
	Comment 8 • 11 years ago

https://tbpl.mozilla.org/?tree=Try&rev=b243553fff42

	Robert Longson [:longsonr] Assignee
	Comment 9 • 11 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/bd5a82670cf9

	Carsten Book [:Tomcat]
	Comment 10 • 11 years ago

https://hg.mozilla.org/mozilla-central/rev/bd5a82670cf9