Robert Longson [:longsonr] Assignee
	Description • 11 years ago

Time for it to retire.

	Daniel Holbert [:dholbert]
	Comment 2 • 11 years ago

Comment on attachment 706769 [details] [diff] [review]
patch

Looks good to me!

	Robert Longson [:longsonr] Assignee
	Comment 3 • 11 years ago

https://tbpl.mozilla.org/?tree=Try&rev=70d0db7b82e2

	Robert Longson [:longsonr] Assignee
	Comment 4 • 11 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/cb77bfbfbda6

	David Zbarsky (:dzbarsky)
	Comment 5 • 11 years ago

Comment on attachment 706769 [details] [diff] [review]
patch

Review of attachment 706769 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/svg/content/src/SVGSVGElement.cpp
@@ +434,2 @@
>    }
> +  // else we're not the outermost <svg> or not bound to a tree, so silently fail

Since this function never throws rv, can you please remove the ErrorResult parameter and the [Throws] annotation in SVGSVGElement.webidl?

@@ +447,5 @@
>  void
>  SVGSVGElement::UnpauseAnimations(ErrorResult& rv)
>  {
> +  if (mTimedDocumentRoot) {
> +    mTimedDocumentRoot->Resume(nsSMILTimeContainer::PAUSE_SCRIPT);

Ditto

@@ +465,5 @@
>  bool
>  SVGSVGElement::AnimationsPaused(ErrorResult& rv)
>  {
> +  nsSMILTimeContainer* root = GetTimedDocumentRoot();
> +  return root && root->IsPausedByType(nsSMILTimeContainer::PAUSE_SCRIPT);

Ditto

@@ +485,5 @@
> +  if (root) {
> +    double fCurrentTimeMs = double(root->GetCurrentTime());
> +    return (float)(fCurrentTimeMs / PR_MSEC_PER_SEC);
> +  } else {
> +    return 0.f;

Ditto

@@ +516,5 @@
> +    //  - Make sure we get an up-to-date paint after this method
> +    //  - re-enable event firing (it got disabled during seeking, and it
> +    //  doesn't get re-enabled until the first sample after the seek -- so
> +    //  let's make that happen now.)
> +    FlushAnimations();

Ditto

	David Zbarsky (:dzbarsky)
	Comment 8 • 11 years ago

Comment on attachment 706906 [details] [diff] [review]
patch

Thanks! r=me

	Ryan VanderMeulen [:RyanVM]
	Comment 9 • 11 years ago

https://hg.mozilla.org/mozilla-central/rev/cb77bfbfbda6

	Robert Longson [:longsonr] Assignee
	Comment 10 • 11 years ago

Comment on attachment 706906 [details] [diff] [review]
patch

Doesn't compile

	Robert Longson [:longsonr] Assignee
	Comment 11 • 11 years ago

Changing the signatures is complicated by the nsIDOMSVGVSGElement interface. I think it's going to need to be a follow up.

	David Zbarsky (:dzbarsky)
	Comment 12 • 11 years ago

OK, I'll do it as part of bug 833446

	Jean-Yves Perrier [:teoli]
	Comment 13 • 10 years ago

As there was no mention of svg.smil.enabled in the reference, I only added a note in 
https://developer.mozilla.org/en-US/Firefox/Releases/21#SVG