Closed
Bug 825004
Opened 12 years ago
Closed 10 years ago
[css-text-decor-3] Unprefix CSS3 Text Decoration
Categories
(Core :: CSS Parsing and Computation, defect)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla36
People
(Reporter: Ms2ger, Assigned: arai)
References
(Blocks 2 open bugs)
Details
(Keywords: dev-doc-complete)
Attachments
(2 files, 1 obsolete file)
80.51 KB,
patch
|
arai
:
review+
|
Details | Diff | Splinter Review |
4.44 KB,
patch
|
dbaron
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Depends on: 812995
Updated•11 years ago
|
Keywords: dev-doc-needed
Thank you for the information. When we drop the prefix, we should make text-decoration a shorthand property of text-decoration-*.
Flags: needinfo?(masayuki)
Assignee | ||
Comment 3•10 years ago
|
||
Unprefixed code, styles, and tests.
Green on try run: https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=0bba8c40f422
I'm also preparing a patch for bug 1039488, code is ready, tests are not yet written.
Attachment #8521158 -
Flags: review?(dbaron)
Comment on attachment 8521158 [details] [diff] [review]
Unprefix CSS3 Text Decoration.
r=dbaron, although we should probably also add aliases of the prefixed properties for a release or two.
This should land at the same time as the aliases and the text-decoration-as-shorthand patch.
Attachment #8521158 -
Flags: review?(dbaron) → review+
Comment on attachment 8521158 [details] [diff] [review]
Unprefix CSS3 Text Decoration.
Thank you for your work!
>diff --git a/layout/style/test/test_transitions_per_property.html b/layout/style/test/test_transitions_per_property.html
>--- a/layout/style/test/test_transitions_per_property.html
>+++ b/layout/style/test/test_transitions_per_property.html
>@@ -77,18 +77,18 @@ var supported_properties = {
> test_length_clamped ],
> "-moz-column-width": [ test_length_transition,
> test_length_clamped ],
> "-moz-image-region": [ test_rect_transition ],
> "-moz-outline-radius-bottomleft": [ test_radius_transition ],
> "-moz-outline-radius-bottomright": [ test_radius_transition ],
> "-moz-outline-radius-topleft": [ test_radius_transition ],
> "-moz-outline-radius-topright": [ test_radius_transition ],
>- "-moz-text-decoration-color": [ test_color_transition,
>- test_border_color_transition ],
>+ "text-decoration-color": [ test_color_transition,
>+ test_border_color_transition ],
> "background-color": [ test_color_transition ],
> "background-position": [ test_background_position_transition,
> // FIXME: We don't currently test clamping,
> // since background-position uses calc() as
> // an intermediate form.
> /* test_length_percent_pair_unclamped */ ],
> "background-size": [ test_background_size_transition,
> // FIXME: We don't currently test clamping,
Isn't this list is ordered from a to z? If so, you should move the lines below. Anyway, thanks!
Assignee | ||
Comment 6•10 years ago
|
||
Thank you for reviewing!
(In reply to David Baron [:dbaron] (UTC-8) (needinfo? for questions) from comment #4)
> Comment on attachment 8521158 [details] [diff] [review]
> Unprefix CSS3 Text Decoration.
>
> r=dbaron, although we should probably also add aliases of the prefixed
> properties for a release or two.
I'll post Part 2 for aliases soon.
(In reply to Masayuki Nakano (:masayuki) (Mozilla Japan) from comment #5)
> Isn't this list is ordered from a to z? If so, you should move the lines
> below. Anyway, thanks!
Yeah, seems that way, fixed.
Attachment #8521158 -
Attachment is obsolete: true
Attachment #8521454 -
Flags: review+
Assignee | ||
Comment 7•10 years ago
|
||
Added aliases.
Green on try run: https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=6bfb27e1ac5d
Attachment #8521455 -
Flags: review?(dbaron)
Comment on attachment 8521455 [details] [diff] [review]
Part 2: Provide temporary aliases for '-moz-text-decoration-*'.
r=dbaron
Could you also file a separate bug on backing this out in a few releases?
Attachment #8521455 -
Flags: review?(dbaron) → review+
Assignee | ||
Comment 9•10 years ago
|
||
Thanks again!
(In reply to David Baron [:dbaron] (UTC-8) (needinfo? for questions) from comment #8)
> Could you also file a separate bug on backing this out in a few releases?
Filed as bug 1097922.
I'll post a patch for bug 1039488 in a few days.
Assignee | ||
Comment 10•10 years ago
|
||
Comment 11•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/ecc30ea0f2c1
https://hg.mozilla.org/mozilla-central/rev/6d55e2ca5c39
Assignee: nobody → arai_a
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
Assignee | ||
Comment 12•10 years ago
|
||
Updated following documents:
https://developer.mozilla.org/en-US/docs/Web/CSS/text-decoration-color
https://developer.mozilla.org/en-US/docs/Web/CSS/text-decoration-line
https://developer.mozilla.org/en-US/docs/Web/CSS/text-decoration-style
https://developer.mozilla.org/en-US/Firefox/Releases/36
Site Compatibility page will be updated after Firefox 36 Aurora is released.
Comment 13•10 years ago
|
||
Thanks :arai! Much appreciated. Made minor fixes to the pages.
Keywords: dev-doc-needed → dev-doc-complete
Blocks: css-text-decor-3
You need to log in
before you can comment on or make changes to this bug.
Description
•