Jason Orendorff [:jorendorff] Assignee
	Description • 12 years ago

The latest draft specifies these methods.

I'm told "items" might be renamed to "entries"; I'll get details on Monday when the latest TC39 meeting notes are posted.

	Luke Wagner [:luke]
	Comment 2 • 12 years ago

Comment on attachment 689856 [details] [diff] [review]
v1

Review of attachment 689856 [details] [diff] [review]:
-----------------------------------------------------------------

Nice.

::: js/src/builtin/MapObject.cpp
@@ +912,5 @@
>          return js_ThrowStopIteration(cx);
>      }
>  
> +    MapObject::IteratorKind kind = thisobj.kind();
> +    if (kind == MapObject::Keys) {

Any reason not to use a switch?  If you avoid 'default', you get the nice warning if you are missing an enumerator.

	Ryan VanderMeulen [:RyanVM]
	Comment 3 • 12 years ago

https://hg.mozilla.org/mozilla-central/rev/8541aa1783c7

	Florian Scholz (Open Web Docs)
	Comment 4 • 10 years ago

Developer release notes:
https://developer.mozilla.org/en-US/Firefox/Releases/20#JavaScript

Reference docs:
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Map/entries
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Map/keys
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Map/values

As always, feel free to review and improve these docs in the MDN wiki. Much appreciated.