Closed
Bug 762120
Opened 12 years ago
Closed 12 years ago
Reftest analyser doesn't work when using baseURL to run TBPL from the local filesystem
Categories
(Tree Management Graveyard :: TBPL, defect)
Tree Management Graveyard
TBPL
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: emorley, Assigned: emorley)
References
Details
Attachments
(1 file)
|
1.71 KB,
patch
|
mbrubeck
:
review+
|
Details | Diff | Splinter Review |
1) Open js/Config.js and change the baseURL to "https://tbpl.mozilla.org/" 2) Open index.html from the TBPL repo root, via local filesystem 3) Find a reftest failure and open the reftest analyser Expected: Spinner then reftest analyser appears. Actual: "Fetching reftest log failed." ---- Example: > data:text/html,<!DOCTYPE html><title>Loading reftest analyzer for ...<snip> > function encode(s) { return escape(s).replace(/=/g, "%3d") } > > NetUtils.loadText("https:\/\/tbpl.mozilla.org\/https:\/\/tbpl.mozilla.org\/php\/getLogExcerpt.php?id=12420128&type=reftest", > function(log) { > window.location.replace("https://hg.mozilla.org/mozilla-central/raw-file/tip/layout/tools/reftest/reftest-analyzer.xhtml#log=" + encode(encode(log))) }, > function() { $("p").removeClass("loading").text("Fetching reftest log failed.") }, > function() { $("p").removeClass("loading").text("Fetching reftest log timed out.") }); > </script> Caused by: http://hg.mozilla.org/users/mstange_themasta.com/tinderboxpushlog/file/b176931d00b8/js/UserInterface.js#l1498 > 1498 'NetUtils.loadText(' + self._makeJSString(baseURL + result.reftestLogURL) + ',\n' + > 1499 ' function(log) { window.location.replace("https://hg.mozilla.org/mozilla-central/raw-file/tip/layout/tools/reftest/reftest-analyzer.xhtml#log=" + encode(encode(log))) },\n' +
|
Assignee | |
Comment 1•12 years ago
|
||
reftestLogURL is defined as:
> "reftestLogURL": Config.baseURL + "php/getLogExcerpt.php?id=" + run._id + '&type=reftest',
So no need to prefix it with baseURL in UserInterface.js as well.
Attachment #630622 -
Flags: review?(mstange)
|
||
Updated•12 years ago
|
Attachment #630622 -
Flags: review?(mstange) → review+
|
|
Assignee | |
Comment 2•12 years ago
|
||
http://hg.mozilla.org/users/mstange_themasta.com/tinderboxpushlog/rev/1388eddadac7
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
|
||
Updated•10 years ago
|
Product: Webtools → Tree Management
|
|
||
Updated•9 years ago
|
Product: Tree Management → Tree Management Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•