Gordon P. Hemsley [:GPHemsley] Assignee
	Description • 12 years ago

I realized that bug 730209 doesn't support BCP 47 language tags that make use of extensions or private use subtags. At present, if such a language tag is the name of a dictionary, it will (I believe) display the entire language tag raw. A better behavior, I think, would be to simply ignore the extension and privateuse subtags if they are unsupported (which they currently are).

In addition, the tests included in that bug are not as exhaustive as they could be, so that should also be improved.

(I have code for this already; patch will be attached shortly.)

	Gordon P. Hemsley [:GPHemsley] Assignee
	Comment 1 • 12 years ago

Updates the regexp and adds a bunch of tests.

	:Gavin Sharp [email: gavin@gavinsharp.com]
	Comment 2 • 12 years ago

Comment on attachment 611861 [details] [diff] [review]
Improve support for extension and privateuse subtags

rs=me

	Gordon P. Hemsley [:GPHemsley] Assignee
	Comment 3 • 12 years ago

Pushed to try:
https://tbpl.mozilla.org/?tree=Try&rev=ba49a841ccef

	Ryan VanderMeulen [:RyanVM]
	Comment 4 • 12 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/62e4dcb92be0

	Gordon P. Hemsley [:GPHemsley] Assignee
	Comment 5 • 12 years ago

Ugh, I forgot to mention explicitly that this code presupposes the code for bug 716321. Since that code is not yet in m-i/m-c, I think we'll wind up with a failing test.

The test on line 106 of toolkit/content/tests/browser/browser_InlineSpellChecker.js ('es-419') should be marked as todo_is.

	Ryan VanderMeulen [:RyanVM]
	Comment 6 • 12 years ago

Changed the test to todo_is.
https://hg.mozilla.org/integration/mozilla-inbound/rev/031f54b05818

	Gordon P. Hemsley [:GPHemsley] Assignee
	Comment 7 • 12 years ago

Here's the patch with the change integrated into, in case it's needed.

	Marco Bonardo [:mak] (Away Apr 25 - May 5)
	Comment 8 • 12 years ago

https://hg.mozilla.org/mozilla-central/rev/62e4dcb92be0

	Marco Bonardo [:mak] (Away Apr 25 - May 5)
	Comment 9 • 12 years ago

and https://hg.mozilla.org/mozilla-central/rev/031f54b05818