Closed Bug 722880 (mtable-width) Opened 12 years ago Closed 12 years ago

Support for attribute "width" on mtable

Categories

(Core :: MathML, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla13

People

(Reporter: fredw, Assigned: francoiswang)

References

()

Details

(Keywords: dev-doc-complete, helpwanted, Whiteboard: [good second bug])

Attachments

(2 files)

Here is a test case from the MathML testsuite:

http://www.w3.org/Math/testsuite/build/main/Presentation/TablesAndMatrices/mtable/mtableAwidth1-full.xhtml

Note that to workaround this bug, MathJax attaches the corresponding style="width: ..." on the mtable element. Hence an easy way to fix this bug would be to do this attribute mapping in src/content/mathml/content/src/nsMathMLElement.cpp. Note the special value "auto" and the case when length is unitless (it should be interpreted in the same way as a % per chapter 2).

Good new, we don't have to care about mstyle:
"MathML specifies that when the attributes height, depth or width are specified on an mstyle element, they apply only to mspace elements, and not to the corresponding attributes of mglyph, mpadded, or mtable."

Here is a reftest I wrote for the MathJax project:

http://devel.mathjax.org/testing/testsuite/MathMLToDisplay/Presentation/TablesAndMatrices/mtable/width-1.html?&outputJax=NativeMML

http://devel.mathjax.org/testing/testsuite/MathMLToDisplay/Presentation/TablesAndMatrices/mtable/width-1-ref.html?&outputJax=NativeMML

(one can also compare the effect of the attribute width with the one of the corresponding style="width: ..." rule)
Assignee: nobody → francoiswang
Attached patch Patch V1Splinter Review
Attachment #599666 - Flags: review?(karlt)
> Here is a reftest I wrote for the MathJax project:
> 
> http://devel.mathjax.org/testing/testsuite/MathMLToDisplay/Presentation/
> TablesAndMatrices/mtable/width-1.html?&outputJax=NativeMML
> 
> http://devel.mathjax.org/testing/testsuite/MathMLToDisplay/Presentation/
> TablesAndMatrices/mtable/width-1-ref.html?&outputJax=NativeMML
> 
> (one can also compare the effect of the attribute width with the one of the
> corresponding style="width: ..." rule)

The reference in this reftest does not work very well for us, because of bug 459363. So maybe we should just compare

<mtable width="...">...

against

<mtable style="width: ...;">...

We can also verify that "auto" is the same as the default value:

<mtable width="auto">...

and

<mtable>...

(I think in attachment 599666 [details] [diff] [review], ParseNumericValue will just ignore "auto" and thus provide the expected behavior here).
Attachment #599666 - Flags: review?(karlt) → review+
Attachment #600810 - Flags: review?(karlt)
Attachment #600810 - Flags: review?(karlt) → review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/c90e1b198f93
https://hg.mozilla.org/mozilla-central/rev/96b6614529b6
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla13
Alias: mtable-width
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: