Heather Arthur [:harth] Reporter
	Description • 13 years ago

The Properties and Rules views don't show :visited styles if the selected element is a visited link.

Firebug has this problem too http://code.google.com/p/fbug/issues/detail?id=4131.
Most likely a result of the privacy changes to :visited style querying in bug 147777.

STR:
* Visit http://harthur.github.com/test-pages/pseudo-classes.html
* Inspect the first link named "visited website" (assuming you've visited google.com)
* Open the Style panel and the Rules view.

Expected result:
In the Rules view: see an "a:visited { color: hotpink; }" rule and a crossed-out, overridden "a:link { color: violet }"

In the Properties view: see "rgb(255, 105, 180)" for the "color" property

Actual result:
In the Rules view: see an un-overridden "a:link { color: violet }" rule, and no :visited rule.

In the Properties view: see "rgb(238, 130, 238)" for the "color" property

	Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]
	Comment 1 • 13 years ago

Yes, we should work out how to better handle pseudo-classes.

	Paul Rouget [:paul]
	Comment 2 • 12 years ago

(this is not related to pseudo-classes)

triage, filter on centaur

	Dirkjan Ochtman (:djc)
	Comment 4 • 12 years ago

Surely the devtools can run with some extra privileges that would allow them to access the accurate visited information?

	Jan Honza Odvarko [:Honza] (always need-info? me)
	Comment 5 • 11 years ago

Could we yet raise the priority of this bug?
It's also a problem for Firebug.

Honza

	kud
	Comment 6 • 10 years ago

I don't see them too on latest firefox nightly 33.0a1 (2014-06-24) and it makes me really sad. :(

	Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]
	Comment 7 • 10 years ago

Note to self:
Search for inspector.togglePseudoClass(':hover') and work from there.

	kud
	Comment 8 • 10 years ago

/browser/devtools/breadcrumbs.js:

```
const PSEUDO_CLASSES = [":hover", ":active", ":focus", ":visited"];
```

instead of

```
const PSEUDO_CLASSES = [":hover", ":active", ":focus"];
```

---

/browser/devtools/breadcrumbs.js:

add:

```
<menuitem id="node-menu-pseudo-visited"
        label=":visited" type="checkbox"
        oncommand="inspector.togglePseudoClass(':visited')"/>
```

	Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]
	Comment 9 • 10 years ago

(In reply to Erwann Mest from comment #8)
> /browser/devtools/breadcrumbs.js:
> 
> ```
> const PSEUDO_CLASSES = [":hover", ":active", ":focus", ":visited"];
> ```
> 
> instead of
> 
> ```
> const PSEUDO_CLASSES = [":hover", ":active", ":focus"];
> ```
> 
> ---
> 
> /browser/devtools/breadcrumbs.js:
> 
> add:
> 
> ```
> <menuitem id="node-menu-pseudo-visited"
>         label=":visited" type="checkbox"
>         oncommand="inspector.togglePseudoClass(':visited')"/>
> ```

I have created a patch for you. I have also done some stuff so that this works remotely and added a test.

	Heather Arthur [:harth] Reporter
	Comment 10 • 10 years ago

We didn't put :visited in because getCSSStyleRules and getComputedStyle won't return rules and properties for :visited nodes, which defeats the purpose. See the blocking bugs.

	kud
	Comment 11 • 10 years ago

Yep, this bug is blocked by another one from platform.

Though, it must be fixed as it works perfectly in chrome and it's disturbing when you're developing a website.

@miker Sorry, I didn't do a patch because I mess my mercurial repo up. I will need to fix it. ;) (I only know git to be honest).

Thank you for your attention anyway.

@harth Do not hesitate to ping me when these bugs are fixed.

	Brian Grinstead [:bgrins]
	Comment 12 • 10 years ago

Comment on attachment 8447441 [details] [diff] [review]
add-visited-styles-713106.patch

Review of attachment 8447441 [details] [diff] [review]:
-----------------------------------------------------------------

The locking works well.  But as mentioned, until we can inspect the styles it doesn't really make sense to include it in the list.

	kud
	Comment 13 • 10 years ago

Yep, true. ;)

	(no longer active)
	Comment 15 • 9 years ago

Has there been any updates here?

	Brian Grinstead [:bgrins]
	Comment 16 • 9 years ago

(In reply to :Ehsan Akhgari [Away: 1/29-2/20] (not reading bugmail, needinfo? me!) from comment #15)
> Has there been any updates here?

From what I understand, once Bugs 729310 and 729692 are resolved we can implement this in the toolbox.

	Potch [:potch]
	Comment 17 • 9 years ago

Just got bitten by this. Any movement on the blockers for this bug?

	Brian Grinstead [:bgrins]
	Comment 18 • 9 years ago

(In reply to Potch [:potch] from comment #17)
> Just got bitten by this. Any movement on the blockers for this bug?

Bug 729310 is assigned (with an r+ed patch), but hasn't had activity for some months - I'll ask over there.  Bug 729692 hasn't had any activity yet.

	Brian Grinstead [:bgrins]
	Comment 19 • 9 years ago

Just rebased

	Tom Tromey :tromey
	Comment 23 • 8 years ago

I think the rule view will also need to be updated in order to show invalid
visited properties to the user.  That is, for the CSS

a:visited {
  color: chartreuse;
  font-size: 23em;
}

... the font-size property should be struck through in the rule view, because
font-size is not on the approved list of properties for :visited
(see https://developer.mozilla.org/en-US/docs/Web/CSS/:visited)

It would be ideal if platform had a method to give out this information
rather than relying on a whitelist in the inspector.

	Alexey Mak
	Comment 27 • 7 years ago

I'd love to know, when or if this will be fixed.
I'm aware of security issues, but isn't is enough time passed for a solution to be made?
As an example only let Inspector get that information and not the scripts.
:visited is like a nemesis of web debugging.

	J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)
	Comment 28 • 7 years ago

(Clearing assignee since I don't think this is in active work.)

We need to make some platform tweaks to expose the necessary info for DevTools and then we should be able to make progress here.

	Pulsebot
	Comment 39 • 5 years ago

Pushed by dakatsuka.birchill@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1eb4d8d47675
Show :visited rule while the pseudo is locked. r=pbro,emilio
https://hg.mozilla.org/integration/autoland/rev/26c7c6044b01
Make :visited selector enabled to use from DevTools. r=pbro,emilio
https://hg.mozilla.org/integration/autoland/rev/205878310d59
Lock/unlock :visited pseudo-class. r=pbro
https://hg.mozilla.org/integration/autoland/rev/636ff6533a6f
Add test for InspectorUtils. r=emilio
https://hg.mozilla.org/integration/autoland/rev/512dabbc915d
Add test for visited element. r=pbro