:Ms2ger (he/him; ⌚ UTC+1/+2) Reporter
	Description • 13 years ago

As discussed.

	Mounir Lamouri (:mounir)
	Comment 2 • 13 years ago

Try server push:
http://tbpl.allizom.org/?tree=Try&usebuildbot=1&rev=9e3d51151949

	Olli Pettay [:smaug][bugs@pettay.fi]
	Comment 3 • 13 years ago

Since .width/.height are mainly for the same use case what img has them, they should work the
same way, IMO.

Could you file a spec bug? (Or explain why the properties in <input type="image"> and <img> should work differently)

	Olli Pettay [:smaug][bugs@pettay.fi]
	Comment 4 • 13 years ago

http://www.w3.org/Bugs/Public/show_bug.cgi?id=14036

	Mounir Lamouri (:mounir)
	Comment 5 • 13 years ago

You are right Olli. I've been naive enough to believe the specs would mess up something that simple but indeed, IE has those two attributes reflected as numbers and having them behaving like the image element seems to make sense.

	Mounir Lamouri (:mounir)
	Comment 6 • 13 years ago

The specs have changed and it should now behave like img.

	Boris Zbarsky [:bzbarsky]
	Comment 8 • 12 years ago

Comment on attachment 636999 [details] [diff] [review]
patch 2

>+nsGenericHTMLElement::GetWidthHeight(imgIRequest *aRequest)

Let's call this "GetWidthHeightForImage".

>+++ b/content/html/content/src/nsGenericHTMLElement.h
>+   * Get width and hight, using given request if attributes are unset.

s/hight/height/ and s/request/image request/


>+++ b/content/html/content/src/nsHTMLInputElement.cpp
>+nsHTMLInputElement::SetHeight(PRUint32 aHeight)
>+{
>+  nsAutoString value;
>+  value.AppendInt(aHeight);
>+
>+  return nsGenericHTMLElement::SetAttr(kNameSpaceID_None, nsGkAtoms::height,
>+                                       value, true);

Document that this is not using SetIntAttr because we have an unsigned integer?

Though maybe we should just add an overload of SetIntAttr that takes PRUint32....

>+nsHTMLInputElement::GetWidth(PRUint32 *aWidth)
>+return NS_OK;

Fix the indent, please.

>+++ b/dom/interfaces/html/nsIDOMHTMLInputElement.idl

Please rev the IID and fix the indentaion here too.

r=me with those nits and a better commit message.  ;)

	Mounir Lamouri (:mounir)
	Comment 9 • 12 years ago

Thank you for working on that Trevor! :)

	:Ms2ger (he/him; ⌚ UTC+1/+2) Reporter
	Comment 10 • 12 years ago

(In reply to Boris Zbarsky (:bz) from comment #8)
> >+++ b/content/html/content/src/nsHTMLInputElement.cpp
> >+nsHTMLInputElement::SetHeight(PRUint32 aHeight)
> >+{
> >+  nsAutoString value;
> >+  value.AppendInt(aHeight);
> >+
> >+  return nsGenericHTMLElement::SetAttr(kNameSpaceID_None, nsGkAtoms::height,
> >+                                       value, true);
> 
> Document that this is not using SetIntAttr because we have an unsigned
> integer?
> 
> Though maybe we should just add an overload of SetIntAttr that takes
> PRUint32....

Something like SetUnsignedIntAttr(), maybe?

	Boris Zbarsky [:bzbarsky]
	Comment 11 • 12 years ago

Seems fine to me.

	Trevor Saunders (:tbsaunde) Assignee
	Comment 12 • 12 years ago

landed https://hg.mozilla.org/integration/mozilla-inbound/rev/b038d3cfa0c3

	Ed Morley [:emorley]
	Comment 13 • 12 years ago

https://hg.mozilla.org/mozilla-central/rev/b038d3cfa0c3

	Jean-Yves Perrier [:teoli]
	Comment 15 • 11 years ago

Documentation updated:
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/Input
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/Input
and
https://developer.mozilla.org/en-US/docs/Mozilla/Firefox/Releases/16