David Bolter [:davidb] (NeedInfo me for attention) Reporter
	Description • 13 years ago

      No description provided.

	Hubert Figuiere [:hub]
	Comment 1 • 13 years ago

see bug 650294 (test disabling)

	Athena Assignee
	Comment 2 • 10 years ago

The test fails because the selected menuitem has an extra '✓' child on a mac -- see http://mxr.mozilla.org/mozilla-central/source/toolkit/themes/osx/global/menu.css#168

So enabling the test with added info for OSX.

	David Bolter [:davidb] (NeedInfo me for attention) Reporter
	Comment 3 • 10 years ago

Comment on attachment 8527123 [details] [diff] [review]
combobox-test-mac-bug-650366.patch

Review of attachment 8527123 [details] [diff] [review]:
-----------------------------------------------------------------

r=me. Thanks!

	Athena Assignee
	Comment 4 • 10 years ago

Comment on attachment 8527123 [details] [diff] [review]
combobox-test-mac-bug-650366.patch

Thanks, already in the uploaded patch.

	David Bolter [:davidb] (NeedInfo me for attention) Reporter
	Comment 5 • 10 years ago

Comment on attachment 8527123 [details] [diff] [review]
combobox-test-mac-bug-650366.patch

Review of attachment 8527123 [details] [diff] [review]:
-----------------------------------------------------------------

Hi Athena, if you have tested the new test locally (on Mac of course) and it passes, please go ahead about put the "checkin-needed" keyword to the bug report itself (not the patch). If you don't have permission to do that ping me :)

	Athena Assignee
	Comment 6 • 10 years ago

Thanks for the pointers! Confirmed passing on a mac.

	Carsten Book [:Tomcat]
	Comment 7 • 10 years ago

David, do we need a try run for this change ?

	David Bolter [:davidb] (NeedInfo me for attention) Reporter
	Comment 8 • 10 years ago

(In reply to Carsten Book [:Tomcat] from comment #7)
> David, do we need a try run for this change ?

Good point - we should! (https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/How_to_Submit_a_Patch#Getting_the_patch_checked_into_the_tree)

Athena I forgot to ask, can you do a tryserver (https://wiki.mozilla.org/Build:TryServerAsBranch#How_to_push_to_try) run? (If you did already you can just say so here and put the checkin-needed keyword back).

	Athena Assignee
	Comment 9 • 10 years ago

Try run here: https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=004f4412fb55

	Carsten Book [:Tomcat]
	Comment 10 • 10 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/69c0c04139a2

	Phil Ringnalda (:philor)
	Comment 11 • 10 years ago

https://hg.mozilla.org/mozilla-central/rev/69c0c04139a2