Kyle Huey (Exited; not receiving bugmail, old account, do not use) Reporter
	Description • 13 years ago

We should turn off incremental linking on release builds (and maybe opt builds if we think it might effect Talos)

"To ensure that your final release build does not contain padding or thunks, link your program nonincrementally." - quoth MSDN

This should probably block Firefox 5 ...

	Kyle Huey (Exited; not receiving bugmail, old account, do not use) Reporter
	Comment 1 • 13 years ago

Per conversations at the all hands, we shouldn't be doing this because PGO should be overriding incremental linking, but we need to verify that we're not doing it before we ship.

	JP Rosevear [:jpr]
	Comment 2 • 13 years ago

Kyle is there a performance hit either in the released application, or for build times?  Is there more details why this is needed for FF5 instead of six weeks later for FF6?

	Kyle Huey (Exited; not receiving bugmail, old account, do not use) Reporter
	Comment 3 • 13 years ago

There is a potential slowdown in the released binary.

	Asa Dotzler [:asa]
	Comment 4 • 13 years ago

Not going to block on this. Will take the possible perf boost for a future release.

	Kyle Huey (Exited; not receiving bugmail, old account, do not use) Reporter
	Comment 5 • 13 years ago

It got turned off globally a while back :-/

	Matheus Kerschbaum
	Comment 6 • 13 years ago

(In reply to Kyle Huey [:khuey] (khuey@mozilla.com) from comment #5)
> It got turned off globally a while back :-/

Only for debug builds, see http://mxr.mozilla.org/mozilla-central/source/toolkit/library/Makefile.in#137