alexander :surkov (:asurkov) Reporter
	Description • 13 years ago

We need to set up selection listeners for controls that has own selection controller like text fields, other controls should be handled presshell selection controller (that is added when document accessible is created). However we need to unregister selection listener for text field controls when something else gets focused.

	alexander :surkov (:asurkov) Reporter
	Comment 1 • 13 years ago

nsCaretAccessible manages the selection listeners (http://mxr.mozilla.org/mozilla-central/source/accessible/src/base/nsCaretAccessible.cpp), see SetControlSelectionListener and ClearControlSelectionListener methods. FocusManager class (FocusManager.cpp in same folder) manages the accessible focus and set selection listeners for control when control gets focused. So FocusManager should take care to remove current selection listener.

Please don't hesitate to ask questions.

	Kushagra Singh [:kushagra]
	Comment 2 • 10 years ago

hi alexander, i would like to take up this bug and work on it. can you please help me out?

	alexander :surkov (:asurkov) Reporter
	Comment 3 • 10 years ago

basically I need to update on comment #1:

you need to fix SelectionManager class (SetControlSelectionListener and ClearControlSelectionListener methods) to make it check weather the frame object has NS_FRAME_INDEPENDENT_SELECTION state. If it doesn't then return early. That's it.

	Mike Hoye [:mhoye]
	Comment 4 • 10 years ago

Hi, Kushagra - Are you still working on this?

	Kushagra Singh [:kushagra]
	Comment 5 • 10 years ago

Hi Mike, I am really sorry. Totally forgot about this bug, will take it up after the weekend if that is fine with you?

	Mike Hoye [:mhoye]
	Comment 6 • 10 years ago

Absolutely, and thank you!

	Kushagra Singh [:kushagra]
	Comment 7 • 10 years ago

Hope the patch is somewhat on the mark.
Can you also please help me out with C++ debugging for the mozilla code.
Thanks :)

	alexander :surkov (:asurkov) Reporter
	Comment 8 • 10 years ago

Comment on attachment 8433366 [details] [diff] [review]
Initial patch.

Review of attachment 8433366 [details] [diff] [review]:
-----------------------------------------------------------------

::: accessible/src/base/SelectionManager.cpp
@@ +38,5 @@
>  
>  void
>  SelectionManager::ClearControlSelectionListener()
>  {
> +  if (!mCurrCtrlFrame || mCurrCtrlFrame->NS_FRAME_INDEPENDENT_SELECTION == NULL)

I think the idea should work but you didn't build it and run automated test suite, right? It looks like you should use GetStates()

	Kevin Mather [:kmather73]
	Comment 9 • 9 years ago

Hi Alexander,
I would like work on this bug. Can you please assign me to it?

	alexander :surkov (:asurkov) Reporter
	Comment 10 • 9 years ago

Let's check if Kushagra works on it

	Kushagra Singh [:kushagra]
	Comment 11 • 9 years ago

Sorry, I won't be able to work on it. Assigning it to Kevin.