:Ms2ger (he/him; ⌚ UTC+1/+2) Assignee
	Description • 14 years ago

As noted in bug 604807, we could remove it. Patches coming up.

	Boris Zbarsky [:bzbarsky]
	Comment 8 • 13 years ago

Comment on attachment 507560 [details] [diff] [review]
Part a: Remove unnecessary inclusions of and references to nsISelectElement.h

r=me

	Boris Zbarsky [:bzbarsky]
	Comment 9 • 13 years ago

Comment on attachment 507561 [details] [diff] [review]
Part b: make nsHTMLOptionElement::GetSelect return nsHTMLSelectElement.

>+    if (aContent &&
>+        aContent->NodeInfo()->Equals(nsGkAtoms::option, kNameSpaceID_XHTML))

As long as you're here:

  if (aContent && aContent->IsHTML(nsGkAtoms::option))

>+++ b/content/html/content/src/nsHTMLSelectElement.h

>+    if (!aContent ||
>+        !aContent->NodeInfo()->Equals(nsGkAtoms::select, kNameSpaceID_XHTML))
>+      return NULL;

Again, IsHTML().  And let's stick with nsnull until the mass-change.  ;)

r=me with the nits picked.

	Boris Zbarsky [:bzbarsky]
	Comment 10 • 13 years ago

Comment on attachment 507562 [details] [diff] [review]
Part c: stop using QueryInterface on nsHTMLOptionElement::GetSelect's return value.

r=me

	Boris Zbarsky [:bzbarsky]
	Comment 11 • 13 years ago

Comment on attachment 507563 [details] [diff] [review]
Part d: use nsHTMLSelectElement::FromContent in nsListControlFrame.

r=me, if you check that stuff like SetOptionsSelectedByIndex can't trigger script (e.g. via onchange events).  If it can, you need to hold strong refs in soe places here...

	Boris Zbarsky [:bzbarsky]
	Comment 12 • 13 years ago

Comment on attachment 507564 [details] [diff] [review]
Part e: make nsSafeOptionListMutation::mSelect a nsHTMLSelectElement.

r=me

	Boris Zbarsky [:bzbarsky]
	Comment 13 • 13 years ago

Comment on attachment 507566 [details] [diff] [review]
Part f: kill layout/forms/resources.

r=me; can't believe this was still around.

	Boris Zbarsky [:bzbarsky]
	Comment 14 • 13 years ago

Comment on attachment 507567 [details] [diff] [review]
Part g: Kill nsISelectElement.

r=me

	:Ms2ger (he/him; ⌚ UTC+1/+2) Assignee
	Comment 15 • 13 years ago

http://hg.mozilla.org/mozilla-central/rev/83b87584d902
http://hg.mozilla.org/mozilla-central/rev/ac5c47d204dc
http://hg.mozilla.org/mozilla-central/rev/98c2bd7b6d53
http://hg.mozilla.org/mozilla-central/rev/e8ac4db006eb
http://hg.mozilla.org/mozilla-central/rev/b71908ead27b
http://hg.mozilla.org/mozilla-central/rev/7ddc7042d30e
http://hg.mozilla.org/mozilla-central/rev/83692ba345d4
http://hg.mozilla.org/mozilla-central/rev/55f92ef9873c