Closed Bug 610365 Opened 14 years ago Closed 14 years ago

[QAC generated] Crash when typing ".." on location bar on File Upload dialog [@ UploadLastDir::StoreLastUsedDirectory ]

Categories

(Core :: Layout: Form Controls, defect)

x86
Linux
defect
Not set
critical

Tracking

()

RESOLVED FIXED
mozilla2.0b8
Tracking Status
blocking2.0 --- final+

People

(Reporter: inhodpr, Assigned: darktrojan)

References

Details

(Keywords: regression)

Attachments

(1 file)

Using Ubuntu 10.04 and Firefox 4.0b8pre

Steps to Reproduce
---------------------------------------
1. Browse to a page with a form with a file upload field
2. Click "Browse..."
3. On the File Upload dialog, type ".."
4. Press enter

What should have happened:
---------------------------------------
The dialog should have changed to the parent folder.

What actually happened:
----------------------------------------
Firefox crashed, closing all open windows.
Confirmed

bp-6f4fd7ad-eb2f-4ee0-9d9a-1b8852101108

http://hg.mozilla.org/mozilla-central/rev/0f92c4e81cf3
Mozilla/5.0 (X11; Linux i686; rv:2.0b8pre) Gecko/20101108 Firefox/4.0b8pre ID:20101108005836
Status: UNCONFIRMED → NEW
Ever confirmed: true
Summary: [QAC generated] Crash when typing ".." on location bar on File Upload dialog → [QAC generated] Crash when typing ".." on location bar on File Upload dialog [@ UploadLastDir::StoreLastUsedDirectory ]
Regression window:
Works:
http://hg.mozilla.org/mozilla-central/rev/1f0e04dc2b21
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.3a1pre) Gecko/20091222 Minefield/3.7a1pre ID:20091222030816
Fails:
http://hg.mozilla.org/mozilla-central/rev/f8b8f2f214d6
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.3a1pre) Gecko/20091223 Minefield/3.7a1pre ID:20091223031109
Pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=1f0e04dc2b21&tochange=f8b8f2f214d6
Regression by:
Bug 524408 - input[type=file] should remember last used directory on a site-by-site basis
Blocks: 524408
Severity: normal → critical
Component: General → Layout: Form Controls
Product: Firefox → Core
QA Contact: general → layout.form-controls
Target Milestone: --- → mozilla2.0
blocking2.0: --- → ?
Keywords: regression
Looks like parentFile is null there.  Does aFile end up pointing to / for some reason?

But yeah, we should fix this...
Geoff, let me know if you don't have time to look into this.
blocking2.0: ? → final+
Attached patch fixSplinter Review
Yes, parentFile is null. Not sure why the file picker is allowed to give us a directory, but that is a bug for another day.
Assignee: nobody → geoff
Status: NEW → ASSIGNED
Attachment #489000 - Flags: review?(bzbarsky)
Attachment #489000 - Flags: review?(bzbarsky)
Attachment #489000 - Flags: review+
Attachment #489000 - Flags: approval2.0+
Keywords: checkin-needed
Pushed http://hg.mozilla.org/mozilla-central/rev/965eda03b734
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: mozilla2.0 → mozilla2.0b8
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: