Closed
Bug 603002
Opened 14 years ago
Closed 14 years ago
History folders labelled with wrong month names
Categories
(Firefox :: Bookmarks & History, defect)
Firefox
Bookmarks & History
Tracking
()
RESOLVED
FIXED
Firefox 4.0b9
People
(Reporter: darktrojan, Assigned: darktrojan)
References
Details
(Whiteboard: [fixed-in-places])
Attachments
(1 file)
1.61 KB,
patch
|
mak
:
review+
sdwilsh
:
approval2.0+
|
Details | Diff | Splinter Review |
It's October 9. In my history I have folders for: * Today (Oct 9) * Yesterday (Oct 8) * Last 7 days (Oct 2 - 9, surely that's 8 days but whatever) * This month (Oct 1 - 9) * August The entry for August contains my history for September, which is as far back as my history goes. This also happens in my Firefox 3.6 profile, it has folders for April - August which contain May - September's history.
Assignee | ||
Comment 1•14 years ago
|
||
Now that it's past midnight UTC the months are labelled correctly. Is there something funky going on when the local date is greater than the UTC date? (I'm 13 hours ahead here.)
Comment 2•14 years ago
|
||
there is most likely still some wrong calculation on the start/end of months. Btw, which version are we talking about? latest nightly? latest beta?
Assignee | ||
Comment 3•14 years ago
|
||
(In reply to comment #2) > there is most likely still some wrong calculation on the start/end of months. > Btw, which version are we talking about? latest nightly? latest beta? Neither - I build from source about once a week. I've just checked Firefox 3.6 on Windows and Ubuntu, and they both have this bug.
Assignee | ||
Comment 4•14 years ago
|
||
Comment 5•14 years ago
|
||
Comment on attachment 484110 [details] [diff] [review] patch ah, interesting! many thanks for findind the bug, appreciate that. I guess if these timezone+DST bugs will ever end :( Asking approval because the patch is really small and pretty much safe, writing a test for this edge case would be quite tricky and orange-prone since it involves specific timezones and corrections, thus I'm not requesting it.
Attachment #484110 -
Flags: review?(mak77)
Attachment #484110 -
Flags: review+
Attachment #484110 -
Flags: approval2.0?
Updated•14 years ago
|
Attachment #484110 -
Flags: approval2.0? → approval2.0+
Assignee | ||
Updated•14 years ago
|
Keywords: checkin-needed
Comment 6•14 years ago
|
||
I'll land this in Places since it would bitrot our current work on central.
Keywords: checkin-needed
Comment 7•14 years ago
|
||
http://hg.mozilla.org/projects/places/rev/debf742b7265 thanks again.
Whiteboard: [fixed-in-places]
Comment 8•14 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/debf742b7265
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 4.0b9
You need to log in
before you can comment on or make changes to this bug.
Description
•