Jesse Ruderman Reporter
	Description • 14 years ago

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.3a5pre) Gecko/20100429 Firefox/3.7a5pre

Steps to reproduce:
1. Tools > Add-ons > Extensions.
2. Find an extension that's enabled.
3. Click the "Disable" button.
4. Quickly click the "Undo" button that appears in its place.

Result: I'm now at the details page for the extension.

Expected: Back to initial state.

	Dave Townsend [:mossop]
	Comment 2 • 14 years ago

Comment on attachment 498553 [details] [diff] [review]
patch

This doesn't seem to quite cover all the cases. I can still double click on the author link to get to the details view. Is there any way we can automatically test this?

	Geoff Lankow (:darktrojan) Assignee
	Comment 3 • 14 years ago

This patch also catches text links and situation where the UI changes between clicks (e.g. the Undo button which disappears).

I can't think of a good way to automate testing. Could write a mochitest I suppose but I don't think that it's worth it.

	Henrik Skupin [:whimboo][⌚️UTC+1]
	Comment 4 • 14 years ago

(In reply to comment #3)
> I can't think of a good way to automate testing. Could write a mochitest I
> suppose but I don't think that it's worth it.

As long as we have the possibility to create automated tests we appreciate to have any of those in the tree.

	Dave Townsend [:mossop]
	Comment 6 • 14 years ago

Comment on attachment 500292 [details] [diff] [review]
patch v2, now with tests

This looks good however since you posted it browser_purchase.js added another case you need to fix. Do that quick correction and then this will be a quick r+ and be ready to land.

	Dave Townsend [:mossop]
	Comment 8 • 14 years ago

Comment on attachment 502151 [details] [diff] [review]
patch v2, updated test

Approved to land after b9

	Dave Townsend [:mossop]
	Comment 9 • 14 years ago

Landed: http://hg.mozilla.org/mozilla-central/rev/fc1817a3d7a4

	Henrik Skupin [:whimboo][⌚️UTC+1]
	Comment 10 • 13 years ago

Verified fixed with Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0b10pre) Gecko/20110119 Firefox/4.0b10pre