Geoff Lankow (:darktrojan) Assignee
	Description • 15 years ago

A file input control contains one file, even if none have been chosen. Presumably this was to clear the textbox of the control, but it's unnecessary. It also results in:
* (javascript) target.files.length = 1
* an empty file being sent over HTTP (although IE and Webkit also do this)

	Jonas Sicking (:sicking) No longer reading bugmail consistently
	Comment 1 • 15 years ago

Comment on attachment 408333 [details] [diff] [review]
proposed fix

>+  void ClearFileNames() {
>+    nsAutoTArray<nsString, 0> fileNames;
>+    SetFileNames(fileNames);
>+  }

Simply use |nsTArray<nsString> fileNames| instead.

And can you add DEBUG-only code to SetFileNames that asserts that none of the file names is an empty string.

Also, can you add a testcase as well? Like modify test_bug523771.html to test that input.files.length == 0 before any files are filled, and after .value is set to "".

	Jonas Sicking (:sicking) No longer reading bugmail consistently
	Comment 3 • 15 years ago

Comment on attachment 408350 [details] [diff] [review]
v2

Awesome, thanks!

	Jonas Sicking (:sicking) No longer reading bugmail consistently
	Comment 4 • 15 years ago

Landed on trunk. Thanks for the patch!

http://hg.mozilla.org/mozilla-central/rev/c9bf888d5fd7

	Jonas Sicking (:sicking) No longer reading bugmail consistently
	Comment 5 • 15 years ago

Branch-patch also containing fix for bug 524421

	Jonas Sicking (:sicking) No longer reading bugmail consistently
	Comment 6 • 15 years ago

Comment on attachment 408724 [details] [diff] [review]
Branch patch

Oops, wrong bug

	Nochum Sossonko [:Natch]
	Comment 7 • 15 years ago

Is this needed/wanted on 1.9.2?

	Jonas Sicking (:sicking) No longer reading bugmail consistently
	Comment 8 • 15 years ago

Oh, crap, yes! I thought it already had landed there

	Jonas Sicking (:sicking) No longer reading bugmail consistently
	Comment 9 • 15 years ago

Comment on attachment 408350 [details] [diff] [review]
v2

Nevermind, this is fixed on 1.9.2. I think I included it in the initial landing of the multiple feature there.

	Nochum Sossonko [:Natch]
	Comment 10 • 15 years ago

So I'll just set the status flag to final-fixed. This will help verify that this was indeed fixed on 1.9.2.

	Tracy Walker [:tracy]
	Comment 11 • 10 years ago

mass remove verifyme requests greater than 4 months old